Handle duplicate names in set_name! #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the code allowed the user to change the name of a component to a value that is already present. That caused the existing component to be silently removed from the system. The code now detects the invalid operation and throws an exception.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 78.14% 78.12% -0.02%
==========================================
Files 49 49
Lines 3994 3996 +2
==========================================
+ Hits 3121 3122 +1
- Misses 873 874 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the code allowed the user to change the name of a component to a value that is already present. That caused the existing component to be silently removed from the system.
The code now detects the invalid operation and throws an exception.