Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cases not handled in previous supplemental attribute PRs #321

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

daniel-thom
Copy link
Contributor

  • Removal of attributes that were attached to multiple components did not work.
  • Searches of components by UUID was slow. This adds an extra dictionary to provide lookup by UUID.

@daniel-thom daniel-thom force-pushed the supplemental-attribute-fixes branch from f56cbd7 to 6026356 Compare January 6, 2024 01:13
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (5558f83) 78.35% compared to head (6026356) 78.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   78.35%   78.46%   +0.10%     
==========================================
  Files          51       51              
  Lines        4084     4123      +39     
==========================================
+ Hits         3200     3235      +35     
- Misses        884      888       +4     
Flag Coverage Δ
unittests 78.46% <70.31%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/supplemental_attribute.jl 80.85% <100.00%> (-1.38%) ⬇️
src/component.jl 94.44% <66.66%> (-1.53%) ⬇️
src/supplemental_attributes.jl 79.16% <12.50%> (-3.49%) ⬇️
src/system_data.jl 90.12% <82.05%> (+1.17%) ⬆️

... and 2 files with indirect coverage changes

@daniel-thom daniel-thom requested a review from jd-lara January 6, 2024 01:31
@jd-lara jd-lara merged commit f0db36a into NREL-Sienna:main Jan 7, 2024
7 of 9 checks passed
@jd-lara jd-lara self-assigned this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants