Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReTest.jl for tests #324

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Use ReTest.jl for tests #324

merged 1 commit into from
Jan 28, 2024

Conversation

daniel-thom
Copy link
Contributor

This PR adopts ReTest.jl in order to make it easier to run subsets of tests.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ac534a) 78.83% compared to head (debadf9) 79.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   78.83%   79.00%   +0.16%     
==========================================
  Files          52       52              
  Lines        4135     4125      -10     
==========================================
- Hits         3260     3259       -1     
+ Misses        875      866       -9     
Flag Coverage Δ
unittests 79.00% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/utils/logging.jl 91.50% <100.00%> (ø)
src/utils/test.jl 83.78% <ø> (+17.82%) ⬆️

... and 1 file with indirect coverage changes

@jd-lara jd-lara self-assigned this Jan 28, 2024
@jd-lara jd-lara merged commit 31ed483 into NREL-Sienna:main Jan 28, 2024
7 of 9 checks passed
Copy link
Contributor

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my initial design-level comments here: NREL-Sienna/PowerSystems.jl#1052 (comment)

@@ -0,0 +1,13 @@
using Revise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like even if the best practice is to install Revise globally, if our tests are going to depend it we ought to have it in test/Project.toml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an oversight. We shouldn't add Revise to the test env

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise definitely gets used in this PR though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default run script for testing in CI doesn't use Revise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants