-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ReTest.jl for tests #324
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 78.83% 79.00% +0.16%
==========================================
Files 52 52
Lines 4135 4125 -10
==========================================
- Hits 3260 3259 -1
+ Misses 875 866 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my initial design-level comments here: NREL-Sienna/PowerSystems.jl#1052 (comment)
@@ -0,0 +1,13 @@ | |||
using Revise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like even if the best practice is to install Revise globally, if our tests are going to depend it we ought to have it in test/Project.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an oversight. We shouldn't add Revise to the test env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revise definitely gets used in this PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default run script for testing in CI doesn't use Revise
This PR adopts ReTest.jl in order to make it easier to run subsets of tests.