Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of supplemental attributes #395

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

daniel-thom
Copy link
Contributor

The default Base.show method was printing circular references to objects internal to supplemental attributes. This solution uses the same method as is used for components.

The default Base.show method was printing circular references to
objects internal to supplemental attributes. This solution uses the same
method as is used for components.
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (0816ef2) to head (16f3306).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          71       71           
  Lines        5484     5484           
=======================================
  Hits         4293     4293           
  Misses       1191     1191           
Flag Coverage Δ
unittests 78.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/utils/print.jl 74.68% <100.00%> (ø)

@jd-lara jd-lara merged commit c235864 into main Sep 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants