Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add Vector of DateTime for Optimization Results #415

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rodrigomha
Copy link
Contributor

We need this for Investment where the timestamps are not necessarily the same resolution.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (cd78bac) to head (91cda2e).

Files with missing lines Patch % Lines
src/Optimization/optimization_problem_results.jl 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   77.75%   77.66%   -0.10%     
==========================================
  Files          69       69              
  Lines        5481     5488       +7     
==========================================
  Hits         4262     4262              
- Misses       1219     1226       +7     
Flag Coverage Δ
unittests 77.66% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Optimization/optimization_problem_results.jl 0.00% <0.00%> (ø)
---- 🚨 Try these New Features:

@@ -1,7 +1,7 @@
# This needs renaming to avoid collision with the DecisionModelResults/EmulationModelResults
mutable struct OptimizationProblemResults <: Results
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just make it a vector and include a new constructor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @jd-lara. We can materialize this into a vector and avoid the union.

@rodrigomha rodrigomha changed the title add Vector of DateTime for Optimization Results [WIP] add Vector of DateTime for Optimization Results Nov 22, 2024
@rodrigomha
Copy link
Contributor Author

This branch will be work in progress for now. I added the case of when there are different time steps for reading results ignoring the timestamps. But will work in a more definitive solution for handling different time stamps for operation, investments and feasibility for SiennaInvestment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants