-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add Vector of DateTime for Optimization Results #415
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 77.75% 77.66% -0.10%
==========================================
Files 69 69
Lines 5481 5488 +7
==========================================
Hits 4262 4262
- Misses 1219 1226 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -1,7 +1,7 @@ | |||
# This needs renaming to avoid collision with the DecisionModelResults/EmulationModelResults | |||
mutable struct OptimizationProblemResults <: Results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just make it a vector and include a new constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @jd-lara. We can materialize this into a vector and avoid the union.
This branch will be work in progress for now. I added the case of when there are different time steps for reading results ignoring the timestamps. But will work in a more definitive solution for handling different time stamps for operation, investments and feasibility for SiennaInvestment. |
We need this for Investment where the timestamps are not necessarily the same resolution.