PSSE Exporter Sync-up #53
Conversation
Those sections being
|
@jd-lara this one also has some remaining TODOs but I think it's time to get someone else's eyes on it. Tagging @HaleyRoss for visibility in case you want to see what it turned into |
GabrielKS
force-pushed
the
hrgks/psse_exporter_psy4
branch
from
ba109fb to
f00e73b
Compare
| @@ -7,16 +7,26 @@ export DCPowerFlow | |||
| export ACPowerFlow | |||
| export PTDFDCPowerFlow | |||
| export vPTDFDCPowerFlow | |||
| export PSSEExportPowerFlow | |||
There was a problem hiding this comment.
Why are we exporting these 2 objects?
There was a problem hiding this comment.
PSSEExportPowerFlow: this is how the user specifies in the network model that the export should be run, see e.g. this test.
PSSEExporter: the user can create one of these themselves to do a PSS/E export from a PSY System manually, not part of a simulation.
| valid_ix, | ||
| neighbors, | ||
| ) | ||
| # TODO: bus_type might need to also be a Matrix since the type can change for a particular scenario |
There was a problem hiding this comment.
Can we make this change in this PR please?
| @@ -0,0 +1,1369 @@ | |||
| const PSSE_EXPORT_SUPPORTED_VERSIONS = [:v33] # TODO add :v34 | |||
| const PSSE_DEFAULT = "" # Used below in cases where we want to insert an empty field to signify the PSSE default | |||
| const PSSE_BUS_TYPE_MAP = Dict( | |||
There was a problem hiding this comment.
We should have a map of this kind in PowerSystems.jl to make it consistent with the parser.
There was a problem hiding this comment.
Yes we should. I suspect there are a lot of things here that should be consolidated with the parser in PSY
src/psse_export.jl
Outdated
| Make a `deepcopy` of the `System` except replace the time series manager and supplemental | ||
| attribute manager with blank versions so these are not copied. | ||
| """ | ||
| function deepcopy_system_no_time_series_no_supplementals(sys::System) |
There was a problem hiding this comment.
@GabrielKS and @daniel-thom should we move this PSY and make a "fast" copy function. Despite the fact that we might move to some other approach, this seems useful in other areas like the saving of the system to results in PowerSimulations.jl
There was a problem hiding this comment.
I'd support that, at least for internal use — if @daniel-thom agrees I'll move it over there and write the tests. I also plan to move with_units to PSY.
There was a problem hiding this comment.
(see previous discussion at #48 (comment))
There was a problem hiding this comment.
Sure, I agree. I do wonder if someone is going to want an option that keeps supplemental attributes.
There was a problem hiding this comment.
Maybe it's fast_deepcopy_system() with kwargs include_time_series and include_supplemental_attributes or something like that
There was a problem hiding this comment.
This large pull request integrates changes into
mainfrom two smaller pull requests, each of which initially drew on work in other branches:plus some more commits only in this branch. Each of those PRs has received some amount of review but has not been scrutinized in detail, so now is the time to do that.