get_resolution not implemented for OptimizationProblemResults

[jd-lara]

Issue in line:

PowerSimulations.jl/src/simulation/decision_model_simulation_results.jl

Line 448 in b405b10

resolution = get_resolution(res)

[GabrielKS]

Reported by @gmantegna

[GabrielKS]

A quick repro using a PowerAnalytics.jl REPL:

] activate test  # must instantiate correctly, etc.
include("test/runtests.jl")  # running the PA tests gives us an `OptimizationProblemResults` to work with
PSI.get_realized_timestamps(problem_results)  # yields `MethodError: no method matching get_resolution(::OptimizationProblemResults)`

[GabrielKS]

The root cause is that get_resolution(res::OptimizationProblemResults) got moved to IS.Optimization and isn't being imported into PSI. It is worth noting that we now have (at least) three different get_resolution functions in three different packages, suggesting that we should put some effort towards standardizing how things are imported from IS:

[GabrielKS]

get_forecast_horizon is four different functions:

[jd-lara]

Yeah, we need to look into the method clean up here for the same function.

[GabrielKS]

For now, I will just add the necessary imports to PSI to resolve this, but let's at some point come up with a principled solution to the whole importing problem here.