Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove incorrect method call #1025

Merged
merged 1 commit into from
Dec 14, 2023
Merged

remove incorrect method call #1025

merged 1 commit into from
Dec 14, 2023

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Dec 13, 2023

This method was called in an incorrect spot. Not having a test make it go through

@jd-lara jd-lara requested a review from daniel-thom December 13, 2023 19:54
@jd-lara jd-lara self-assigned this Dec 13, 2023
@jd-lara jd-lara mentioned this pull request Dec 13, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

Performance Results

Version Precompile Time
Main 6.897955012
This Branch 6.976034421
Version Build Time
Main-Build Time Precompile 61.159574803
Main-Build Time Postcompile 2.773883827
This Branch-Build Time Precompile 64.497439911
This Branch-Build Time Postcompile 3.014003076

@jd-lara jd-lara merged commit 2967d15 into main Dec 14, 2023
7 checks passed
@jd-lara jd-lara deleted the jd/fix_interface_mistaken_code branch December 15, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-thom daniel-thom daniel-thom approved these changes

Assignees

@jd-lara jd-lara

Labels
code bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jd-lara @daniel-thom