Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached time series UUID #1169

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Use cached time series UUID #1169

merged 1 commit into from
Oct 31, 2024

Conversation

daniel-thom
Copy link
Contributor

This code was consuming a lot of time to lookup time series UUIDs when those values are already cached.

It should address NREL-Sienna/InfrastructureSystems.jl#409

This code was consuming a lot of time to lookup time series UUIDs when
those values are already cached.
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (59ee821) to head (1bbe274).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rc/parameters/update_container_parameter_values.jl 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files         121      121           
  Lines       13089    13089           
=======================================
  Hits        10000    10000           
  Misses       3089     3089           
Flag Coverage Δ
unittests 76.40% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/parameters/update_container_parameter_values.jl 34.76% <66.66%> (ø)

Copy link
Contributor

Performance Results

Version Precompile Time
Main 3.682032262
This Branch 3.702582527
Version Build Time
Main-Build Time Precompile 60.863001896
Main-Build Time Postcompile 1.022429476
This Branch-Build Time Precompile 60.794220914
This Branch-Build Time Postcompile 1.049939084
Version Solve Time
Main-Solve Time Precompile 501.500169951
Main-Solve Time Postcompile 463.313561925
This Branch-Solve Time Precompile 405.770839458
This Branch-Solve Time Postcompile 369.292808015

Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquimg this should partially solve some of the problems from the profiling

@jd-lara jd-lara self-assigned this Oct 31, 2024
@jd-lara jd-lara merged commit 01a1bc6 into main Oct 31, 2024
10 of 11 checks passed
@jd-lara jd-lara deleted the is-issue-409 branch December 13, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants