Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PR for Fuel Cost #1180

Merged
merged 19 commits into from
Dec 11, 2024
Merged

New PR for Fuel Cost #1180

merged 19 commits into from
Dec 11, 2024

Conversation

rodrigomha
Copy link
Contributor

Was getting issues with rebasing properly. Tests are passing locally, except for a bug in a initialization example. This test is also failing in the main branch.

test_initialization_problem: Decision Model test for Initialization with RTS GMLC system, Case 4: Error During Test at /Users/rhenriqu/PSY_Renaming/PowerSimulations.jl/test/test_initialization_problem.jl:159
  Got exception outside of a @test
  KeyError: key "Bacon" not found
  Stacktrace:
    [1] getindex
      @ ./dict.jl:498 [inlined]
    [2] _get_ts_uuid
      @ ~/PSY_Renaming/PowerSimulations.jl/src/core/parameters.jl:50 [inlined]
    [3] get_parameter_column_refs(attributes::PowerSimulations.TimeSeriesAttributes{Deterministic}, param_array::JuMP.Containers.DenseAxisArray{Float64, 2, Tuple{Vector{String}, UnitRange{Int64}}, Tuple{JuMP.Containers._AxisLookup{Dict{String, Int64}}, JuMP.Containers._AxisLookup{Tuple{Int64, Int64}}}}, column::String)
      @ PowerSimulations ~/PSY_Renaming/PowerSimulations.jl/src/core/parameters.jl:127
    [4] get_parameter_column_refs(container::PowerSimulations.ParameterContainer{JuMP.Containers.DenseAxisArray{Float64, 2, Tuple{Vector{String}, UnitRange{Int64}}, Tuple{JuMP.Containers._AxisLookup{Dict{String, Int64}}, JuMP.Containers._AxisLookup{Tuple{Int64, Int64}}}}, JuMP.Containers.DenseAxisArray{Float64, 2, Tuple{Vector{String}, UnitRange{Int64}}, Tuple{JuMP.Containers._AxisLookup{Dict{String, Int64}}, JuMP.Containers._AxisLookup{Tuple{Int64, Int64}}}}}, column::String)
      @ PowerSimulations ~/PSY_Renaming/PowerSimulations.jl/src/core/parameters.jl:111
    [5] add_to_expression!(container::PowerSimulations.OptimizationContainer, ::Type{ActivePowerBalance}, ::Type{ActivePowerTimeSeriesParameter}, devices::InfrastructureSystems.FlattenIteratorWrapper{PowerLoad, Vector{Base.ValueIterator}}, device_model::DeviceModel{PowerLoad, StaticPowerLoad}, network_model::NetworkModel{CopperPlatePowerModel})
      @ PowerSimulations ~/PSY_Renaming/PowerSimulations.jl/src/devices_models/devices/common/add_to_expression.jl:695
    [6] construct_device!(container::PowerSimulations.OptimizationContainer, sys::System, ::InfrastructureSystems.Optimization.ArgumentConstructStage, model::DeviceModel{PowerLoad, StaticPowerLoad}, network_model::NetworkModel{CopperPlatePowerModel})
      @ PowerSimulations ~/PSY_Renaming/PowerSimulations.jl/src/devices_models/device_constructors/load_constructor.jl:325
    [7] macro expansion
      @ ~/PSY_Renaming/PowerSimulations.jl/src/core/optimization_container.jl:647 [inlined]
    [8] macro expansion
      @ ~/.julia/packages/TimerOutputs/NRdsv/src/TimerOutput.jl:237 [inlined]
    [9] build_impl!(container::PowerSimulations.OptimizationContainer, template::ProblemTemplate, sys::System)
      @ PowerSimulations ~/PSY_Renaming/PowerSimulations.jl/src/core/optimization_container.jl:645
   [10] build_initial_conditions_model!(model::DecisionModel{GenericOpProblem})
      @ PowerSimulations ~/PSY_Renaming/PowerSimulations.jl/src/initial_conditions/initialization.jl:90
   [11] build_initial_conditions!(model::DecisionModel{GenericOpProblem})
      @ PowerSimulations ~/PSY_Renaming/PowerSimulations.jl/src/operation/operation_model_interface.jl:183
   [12] setup_ic_model_container!(model::DecisionModel{GenericOpProblem})
      @ Main ~/PSY_Renaming/PowerSimulations.jl/test/test_utils/mock_operation_models.jl:230
   [13] macro expansion
      @ ~/PSY_Renaming/PowerSimulations.jl/test/test_initialization_problem.jl:179 [inlined]

@rodrigomha rodrigomha requested a review from jd-lara December 5, 2024 00:00
@jd-lara jd-lara merged commit 8a5d25b into main Dec 11, 2024
3 of 8 checks passed
@jd-lara jd-lara deleted the rh/new_fuelcost_ts branch December 11, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants