Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/custom model improvements #988

Merged
merged 171 commits into from
Sep 6, 2023
Merged

Jd/custom model improvements #988

merged 171 commits into from
Sep 6, 2023

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jul 11, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

Performance Results

Version Precompile Time
Main 8.258399486
This Branch 8.217623569
Version Build Time
Main-Build Time Precompile 76.059718162
Main-Build Time Postcompile 3.91645637
This Branch-Build Time Precompile 77.851739625
This Branch-Build Time Postcompile 3.880919679

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #988 (1ebb9a7) into main (c635de1) will decrease coverage by 0.63%.
Report is 65 commits behind head on main.
The diff coverage is 62.19%.

❗ Current head 1ebb9a7 differs from pull request most recent head 33fe60b. Consider uploading reports for the commit 33fe60b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
- Coverage   81.00%   80.38%   -0.63%     
==========================================
  Files         116      115       -1     
  Lines       12121    12283     +162     
==========================================
+ Hits         9819     9874      +55     
- Misses       2302     2409     +107     
Flag Coverage Δ
unittests 80.38% <62.19%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/PowerSimulations.jl 37.50% <ø> (ø)
src/core/network_model.jl 88.33% <ø> (+2.61%) ⬆️
src/core/variables.jl 65.75% <0.00%> (+0.88%) ⬆️
...device_constructors/hydrogeneration_constructor.jl 92.85% <ø> (ø)
...vices_models/devices/common/objective_functions.jl 82.95% <ø> (ø)
src/devices_models/devices/thermal_generation.jl 90.73% <0.00%> (+0.52%) ⬆️
...ation/initial_conditions_update_in_memory_store.jl 71.42% <0.00%> (-11.91%) ⬇️
src/operation/operation_problem_templates.jl 100.00% <ø> (ø)
src/parameters/add_parameters.jl 65.30% <0.00%> (-5.03%) ⬇️
src/parameters/update_parameters.jl 39.62% <0.00%> (-3.19%) ⬇️
... and 21 more

... and 11 files with indirect coverage changes

@jd-lara jd-lara merged commit 4fc6be7 into main Sep 6, 2023
@jd-lara jd-lara deleted the jd/custom_model_improvements branch September 12, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants