Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ST8C, DEGOV1 and TGSimple models. Also, remove Windows PR Testing temporarily #390

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

rodrigomha
Copy link
Contributor

@rodrigomha rodrigomha commented Sep 10, 2024

Tests are passing locally with PSY main, but we need a new release of PSY for this test to pass.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Performance Results

Version Precompile Time
Main 1.946192366
This Branch 1.966989072
Version Execute Time
Main-Build ResidualModel 7.729201866
Main-Execute ResidualModel 16.544526572
Main-Build MassMatrixModel 0.619487329
Main-Execute MassMatrixModel 32.666862513
This Branch-Build ResidualModel 7.173901082
This Branch-Execute ResidualModel 16.917629562
This Branch-Build MassMatrixModel 0.619157398
This Branch-Execute MassMatrixModel 32.462768306

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 95.36424% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (c94d006) to head (2db5322).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...rc/initialization/generator_components/init_avr.jl 93.33% 5 Missing ⚠️
src/models/generator_models/avr_models.jl 96.61% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   87.36%   87.14%   -0.23%     
==========================================
  Files          65       66       +1     
  Lines        9143     9853     +710     
==========================================
+ Hits         7988     8586     +598     
- Misses       1155     1267     +112     
Flag Coverage Δ
unittests 87.14% <95.36%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/post_processing/post_proc_generator.jl 90.89% <100.00%> (+1.74%) ⬆️
src/models/generator_models/avr_models.jl 98.85% <96.61%> (-0.24%) ⬇️
...rc/initialization/generator_components/init_avr.jl 94.65% <93.33%> (-0.83%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@SebastianManriqueM SebastianManriqueM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@rodrigomha rodrigomha changed the title Add ST8C and Remove Windows PR Testing temporarily Add ST8C, DEGOV1 and TGSimple models. Also, remove Windows PR Testing temporarily Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants