Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/fix modified rts #101

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Jd/fix modified rts #101

merged 4 commits into from
Jul 2, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jul 2, 2024

This PR addresses the change in the table data parser and also improves the logic behind perturbing the costs in the RTS system to create cost imbalances.

@jd-lara jd-lara requested a review from rodrigomha July 2, 2024 22:02
@jd-lara jd-lara self-assigned this Jul 2, 2024
@jd-lara jd-lara requested a review from GabrielKS July 2, 2024 22:02
src/library/psi_library.jl Outdated Show resolved Hide resolved
src/library/psi_library.jl Outdated Show resolved Hide resolved
src/library/psi_library.jl Outdated Show resolved Hide resolved
src/library/psi_library.jl Outdated Show resolved Hide resolved
@jd-lara
Copy link
Member Author

jd-lara commented Jul 2, 2024

@rodrigomha and @GabrielKS there is some missing logic. I can't figure out how to update the initial input values in a way that makes sense. Also, there are some value that are WAY outside like 1.2277399988805898e6

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (f672cb2) to head (d1396c5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   94.26%   94.29%   +0.02%     
==========================================
  Files          15       15              
  Lines        3313     3312       -1     
==========================================
  Hits         3123     3123              
+ Misses        190      189       -1     
Flag Coverage Δ
unittests 94.29% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/library/psi_library.jl 98.37% <100.00%> (+0.19%) ⬆️

@jd-lara jd-lara added the enhancement New feature or request label Jul 2, 2024
Copy link
Collaborator

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great idea to normalize to reduce the huge number of the initial input. Another option would be to multiply by fuel cost and then divide.

@jd-lara jd-lara merged commit 517429a into main Jul 2, 2024
8 checks passed
@jd-lara jd-lara deleted the jd/fix_modified_RTS branch July 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants