-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jd/fix modified rts #101
Jd/fix modified rts #101
Conversation
@rodrigomha and @GabrielKS there is some missing logic. I can't figure out how to update the initial input values in a way that makes sense. Also, there are some value that are WAY outside like |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 94.26% 94.29% +0.02%
==========================================
Files 15 15
Lines 3313 3312 -1
==========================================
Hits 3123 3123
+ Misses 190 189 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great idea to normalize to reduce the huge number of the initial input. Another option would be to multiply by fuel cost and then divide.
This PR addresses the change in the table data parser and also improves the logic behind perturbing the costs in the RTS system to create cost imbalances.