Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for psy4 branches #76

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix CI for psy4 branches #76

merged 1 commit into from
Feb 28, 2024

Conversation

daniel-thom
Copy link
Contributor

No description provided.

@@ -1,5 +1,5 @@
const PACKAGE_DIR = joinpath(dirname(dirname(pathof(PowerSystemCaseBuilder))))
const DATA_DIR = joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-2.0")
const DATA_DIR = joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-3.0-alpha")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
const DATA_DIR = joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-3.0-alpha")
const DATA_DIR =
joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-3.0-alpha")

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (psy4@7c45cfa). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             psy4      #76   +/-   ##
=======================================
  Coverage        ?   93.05%           
=======================================
  Files           ?       15           
  Lines           ?     3339           
  Branches        ?        0           
=======================================
  Hits            ?     3107           
  Misses          ?      232           
  Partials        ?        0           
Flag Coverage Δ
unittests 93.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@daniel-thom daniel-thom merged commit 5e425c3 into psy4 Feb 28, 2024
6 of 8 checks passed
@daniel-thom daniel-thom deleted the psy4-ci branch February 28, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants