Jd/fix cost functions #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
GabrielKS
requested changes
May 13, 2024
| return base_sys | ||
| end | ||
|
|
||
| function build_linear_fuel_test_sys(; kwargs...) |
There was a problem hiding this comment.
Nitpick: could eliminate duplication by defining a helper function
function build_cost_test_sys(gen_func; kwargs...)
...
test_gen = gen_func(node)
...
end(or fold this into _build_cost_base_test_sys) and then each of these is like
Suggested change
| function build_linear_fuel_test_sys(; kwargs...) | |
| build_linear_fuel_test_sys(; kwargs...) = | |
| build_cost_test_sys(thermal_generator_linear_fuel; kwargs...) |
|
Depends on NREL-Sienna/PowerSystemsTestData#54 |
rodrigomha
approved these changes
May 13, 2024
There was a problem hiding this comment.
This looks good. I can take care of testing all of these in NREL-Sienna/PowerSimulations.jl#1104
GabrielKS
approved these changes
May 13, 2024
|
I'll merge, and if we need more, we should open more. I don't want to make these very large PRs a common thing. @rodrigomha, note that in some cases, there is non-sensical existing data already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new cases for cost function implementation testing