Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSY4] Line rate and storage naming updates #95

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

rodrigomha
Copy link
Collaborator

@rodrigomha rodrigomha commented Jun 9, 2024

No description provided.

@rodrigomha rodrigomha requested a review from jd-lara June 9, 2024 02:49
@rodrigomha rodrigomha marked this pull request as ready for review June 10, 2024 19:47
@rodrigomha
Copy link
Collaborator Author

@jd-lara This is ready for review. We only need to revert the DATA_DIR changes once the new artifact for TestData with PR: NREL-Sienna/PowerSystemsTestData#57 is available

src/definitions.jl Outdated Show resolved Hide resolved
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update artifacts to use the correct reference to TestData

@jd-lara jd-lara merged commit 1eff958 into psy4 Jun 11, 2024
0 of 6 checks passed
@jd-lara jd-lara deleted the rh/psy4_names_updates branch June 11, 2024 22:27
@@ -1,6 +1,5 @@
const PACKAGE_DIR = joinpath(dirname(dirname(pathof(PowerSystemCaseBuilder))))
const DATA_DIR =
joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-3.0-alpha2")
const DATA_DIR = joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-3.0-alpha3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
const DATA_DIR = joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-3.0-alpha3")
const DATA_DIR =
joinpath(LazyArtifacts.artifact"CaseData", "PowerSystemsTestData-3.0-alpha3")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants