Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the bus name convention #1036

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 9, 2024

Given the way that the PowerFlowData is structured, it isn't possible to use formatter for these kinds data inputs.

@jd-lara jd-lara requested a review from daniel-thom January 9, 2024 04:45
@jd-lara jd-lara self-assigned this Jan 9, 2024
@jd-lara jd-lara added the PARSING issues related to parsing come label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (073ae04) 85.35% compared to head (718bf10) 85.38%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
+ Coverage   85.35%   85.38%   +0.02%     
==========================================
  Files         170      170              
  Lines        7691     7689       -2     
==========================================
  Hits         6565     6565              
+ Misses       1126     1124       -2     
Flag Coverage Δ
unittests 85.38% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/parsers/powerflowdata_data.jl 0.00% <0.00%> (ø)

@jd-lara jd-lara merged commit 9d6e1bf into main Jan 10, 2024
10 of 11 checks passed
@jd-lara jd-lara deleted the jd/pfdata_bus_naming_convention branch January 10, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PARSING issues related to parsing come
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants