Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case sensitivity in enum parsers #1045

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

GabrielKS
Copy link
Collaborator

parse_enum_mapping was converting input to uppercase but the keys of the underlying dictionary were not all uppercase, so, e.g., parse_enum_mapping(PrimeMovers, "PVe") wouldn't work and #849 wasn't truly solved. Now everything is Unicode.normalize(casefold=true)'d on both sides.

src/parsers/common.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d6e1bf) 85.38% compared to head (d33e2f8) 85.38%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1045   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         170      170           
  Lines        7689     7689           
=======================================
  Hits         6565     6565           
  Misses       1124     1124           
Flag Coverage Δ
unittests 85.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/parsers/common.jl 66.66% <100.00%> (ø)

@GabrielKS GabrielKS changed the title Fix case sensitivity in PrimeMovers enum parser Fix case sensitivity in enum parsers Jan 31, 2024
src/parsers/common.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@daniel-thom daniel-thom merged commit 38fdb0f into main Feb 1, 2024
11 checks passed
@jd-lara jd-lara deleted the gks/fix-primemovers-parse branch February 5, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants