Fix case sensitivity in enum parsers #1045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_enum_mapping
was converting input to uppercase but the keys of the underlying dictionary were not all uppercase, so, e.g.,parse_enum_mapping(PrimeMovers, "PVe")
wouldn't work and #849 wasn't truly solved. Now everything isUnicode.normalize(casefold=true)
'd on both sides.