Add support for subsystems #1047
Conversation
There was a problem hiding this comment.
The changes look good to me and the functionality is what we can cover without the implementation in PowerSimulations. I think that we can merge this branch and work in subsequent PR's if new issues come to light.
@tengis-nrl can also open PRs with the testing data to increase the confidence in this code.
|
|
||
| """ | ||
| Return a Generator of all components in the subsystem. | ||
|
|
There was a problem hiding this comment.
Are we missing some code here?
There was a problem hiding this comment.
Management of subsystems occurs in the InfrastructureSystems (IS) layer. We implement storage of components and related objects in this sub-package so that other packages can benefit from the logic. The real function is here: https://github.com/daniel-thom/InfrastructureSystems.jl/blob/subsystems/src/subsystems.jl#L74
daniel-thom
force-pushed
the
subsystems
branch
from
20ded92 to
0b94d9b
Compare
This requires InfrastructureSystems code from NREL-Sienna/InfrastructureSystems.jl#326. So, CI will fail.