Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the failed test #1058

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fixing the failed test #1058

merged 2 commits into from
Feb 21, 2024

Conversation

tengis-nrl
Copy link
Collaborator

tests_passing_subsystems Thanks for opening a PR to PowerSystems.jl, please take note of the following when making a PR:

Check the contributor guidelines

  1. Add a description of the changes proposed in the pull request.
  2. Is my PR fixing an open issue? Add the reference to the related issue
  3. If you are contributing a new struct: please refer to the testing requirements for new structs

Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-20 at 3 12 41 PM This is still failing for me when I (merge with `psb4` locally to get the changes since these branches diverged and then) run the full test suite with `pkg> test`. It also fails when I `TestEnv.activate()` and then step through the test in the REPL.

@GabrielKS
Copy link
Collaborator

GabrielKS commented Feb 20, 2024

My guess is the issue is that you are relying on a list of components from get_components to be sorted in a particular way when you do get_name(components[14]); I don't think this is something that get_components guarantees. That would also explain why the test sometimes works for you.

@tengis-nrl
Copy link
Collaborator Author

Does it give you the same error @GabrielKS?

@tengis-nrl
Copy link
Collaborator Author

@GabrielKS Try now. I replaced the index access with get_component

@GabrielKS GabrielKS self-requested a review February 20, 2024 23:28
Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-20 at 4 27 56 PM

Now it works for me

@GabrielKS GabrielKS merged commit e097fec into psy4 Feb 21, 2024
1 of 8 checks passed
@jd-lara jd-lara deleted the 2_subsystems branch February 26, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants