Repair StandardLoad parsing from .mat/.raw files #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 85.18% 85.25% +0.06%
==========================================
Files 170 170
Lines 7702 7695 -7
==========================================
- Hits 6561 6560 -1
+ Misses 1141 1135 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@HaleyRoss can you add a test for this please? |
jd-lara
reviewed
Mar 15, 2024
| @@ -485,7 +483,7 @@ function make_thermal_gen(gen_name::AbstractString, d::Dict, bus::ACBus, sys_mba | |||
| thermal_gen = ThermalStandard(; | |||
| name = gen_name, | |||
| status = Bool(d["gen_status"]), | |||
| available = true, | |||
| available = Bool(d["gen_status"]), | |||
jd-lara
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed if statement from the read_loads!() function that caused StandardLoads being read from .mat and .raw files to be dropped if the constant_active_power and constant_reactive_power arguments were 0.
This is correcting issue #1032