Move ComponentSelector from PowerAnalytics to InfrastructureSystems: PSY portion #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
GabrielKS
commented
Mar 27, 2024
GabrielKS
force-pushed
the
gks/td/component_selector_port
branch
from
bf9f7cd to
29ff85c
Compare
GabrielKS
changed the base branch from
gks/td/component_selector_feature
to
psy4
|
Rebased onto |
GabrielKS
force-pushed
the
gks/td/component_selector_port
branch
from
38921c6 to
28e0767
Compare
- Originally, all `ComponentSelector`s always filtered out components marked not available. This is what we want in `PowerAnalytics`, but not necessarily what is wanted if `ComponentSelector` is used elsewhere. The solution is to not automatically perform this filtering but add it as an option so that `PowerAnalytics` can still have it. - This commit also defines the behavior that using a `TopologyComponentSelector` on a system that does not have that topology element returns no components/subselectors.
GabrielKS
force-pushed
the
gks/td/component_selector_port
branch
from
28e0767 to
3af10e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR will get filled in as @tengis-nrl and I move the ComponentSelector features from PowerAnalytics to InfrastructureSystems.