Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Miscellaneous Costs Cleanup #1097

Merged
merged 3 commits into from
May 2, 2024
Merged

More Miscellaneous Costs Cleanup #1097

merged 3 commits into from
May 2, 2024

Conversation

GabrielKS
Copy link
Collaborator

Miscellaneous cleanup:

  1. Remove the import from IS of get_raw_data as it no longer exists
  2. Make the hydro cost struct default constructor use a CostCurve as it is simpler to deal with

@GabrielKS GabrielKS changed the title Gks/costs 2 cleanup 2 More Miscellaneous Costs Cleanup May 1, 2024
@GabrielKS GabrielKS marked this pull request as ready for review May 2, 2024 16:42
@GabrielKS GabrielKS requested a review from jd-lara May 2, 2024 16:43
@jd-lara jd-lara self-assigned this May 2, 2024
@jd-lara jd-lara merged commit f805903 into psy4 May 2, 2024
1 of 8 checks passed
@jd-lara jd-lara deleted the gks/costs_2_cleanup_2 branch May 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-lara jd-lara jd-lara approved these changes

Assignees

@jd-lara jd-lara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielKS @jd-lara