Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change getters #1099

Merged
merged 2 commits into from
May 8, 2024
Merged

change getters #1099

merged 2 commits into from
May 8, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented May 6, 2024

Thanks for opening a PR to PowerSystems.jl, please take note of the following when making a PR:

Check the contributor guidelines

  1. Add a description of the changes proposed in the pull request.
  2. Is my PR fixing an open issue? Add the reference to the related issue
  3. If you are contributing a new struct: please refer to the testing requirements for new structs

@jd-lara jd-lara requested a review from GabrielKS May 8, 2024 21:02
@jd-lara jd-lara marked this pull request as ready for review May 8, 2024 21:02
GabrielKS
GabrielKS requested changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the typo is fixed

src/models/cost_functions/StorageCost.jl Outdated Show resolved Hide resolved
@jd-lara jd-lara merged commit 7aeef86 into psy4 May 8, 2024
1 of 8 checks passed
@jd-lara jd-lara self-assigned this May 8, 2024
@jd-lara jd-lara deleted the jd/missing_methods_psi branch May 21, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielKS GabrielKS GabrielKS requested changes

Assignees

@jd-lara jd-lara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jd-lara @GabrielKS