Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate time series functionality for MarketBidCost #1103

Merged
merged 6 commits into from
May 13, 2024

Conversation

GabrielKS
Copy link
Collaborator

@GabrielKS GabrielKS commented May 9, 2024

Depends on NREL-Sienna/InfrastructureSystems.jl#367. Here we:

  • Add a validation function is_market_bid_curve and factory function make_market_bid_curve to deal with market bid curves, which are CostCurve{PiecewiseIncrementalCurve}s with NaN first x-coordinate and initial input.
  • Make the market bid cost time series return time arrays of these objects, even though they must be constructed with time series of FunctionData.
  • Rewrite cost_function_timeseries.jl so that less logic has to be duplicated for every new field that works this way
  • Make no_load_cost and start_up fields of MarketBidCost work this way

src/models/cost_function_timeseries.jl Outdated Show resolved Hide resolved
src/models/cost_functions/MarketBidCost.jl Outdated Show resolved Hide resolved
src/models/cost_functions/MarketBidCost.jl Outdated Show resolved Hide resolved
src/models/cost_functions/ValueCurves.jl Outdated Show resolved Hide resolved
src/models/cost_functions/ValueCurves.jl Outdated Show resolved Hide resolved
test/test_cost_functions.jl Outdated Show resolved Hide resolved
test/test_cost_functions.jl Outdated Show resolved Hide resolved
test/test_cost_functions.jl Outdated Show resolved Hide resolved
test/test_cost_functions.jl Outdated Show resolved Hide resolved
test/test_cost_functions.jl Outdated Show resolved Hide resolved
@GabrielKS GabrielKS self-assigned this May 9, 2024
@GabrielKS GabrielKS marked this pull request as ready for review May 10, 2024 18:38
@GabrielKS GabrielKS requested review from daniel-thom and jd-lara May 10, 2024 18:38
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabrielKS we can merge and add methods as needed during the PSI integration

@jd-lara jd-lara merged commit 388906d into psy4 May 13, 2024
1 of 8 checks passed
@jd-lara jd-lara deleted the gks/market_bid_time_series branch June 4, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants