Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pretty Cost Printing #1125

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Add Pretty Cost Printing #1125

merged 6 commits into from
Jun 14, 2024

Conversation

GabrielKS
Copy link
Collaborator

@GabrielKS GabrielKS commented Jun 12, 2024

Fixes #1048. Depends on NREL-Sienna/InfrastructureSystems.jl#377.

Here's how the new cost struct printouts look at their most complicated (printing some operational costs):
Screenshot 2024-06-12 at 5 11 50 PM

Next is to figure out a way of abbreviating this to stick it into the components printout.

@GabrielKS GabrielKS changed the base branch from main to psy4 June 12, 2024 23:16
@GabrielKS
Copy link
Collaborator Author

Okay, now components show more cost information than before but still a very abbreviated summary to more or less fit on one line:
Screenshot 2024-06-14 at 1 09 32 PM
Screenshot 2024-06-14 at 1 10 01 PM
Screenshot 2024-06-14 at 1 10 19 PM

Copy link
Contributor

@kdayday kdayday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "(a type of InputOutputCurve)" necessary? We haven't focused on InputOutputCurve elsewhere in documentation, so I think it could be extraneous and confusing

Also, could shorten "composed of" to "with" or something, but otherwise, looks good

@GabrielKS
Copy link
Collaborator Author

Is "(a type of InputOutputCurve)" necessary? We haven't focused on InputOutputCurve elsewhere in documentation, so I think it could be extraneous and confusing

My thinking was we want to make it super clear when things are input-output curves versus incremental/marginal curves, etc., but I agree that using type names that aren't otherwise very exposed is confusing. Thoughts on another way to do this, or do you think it's already sufficiently clear that this is an input-output curve?

@jd-lara jd-lara merged commit 497d690 into psy4 Jun 14, 2024
1 of 8 checks passed
@jd-lara jd-lara deleted the gks/add_costs_printing branch June 27, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pretty print REPL methods for operation cost
3 participants