Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here, discussed with @rodrigomha, is to allow a user of the
ValueCurve
cost aliases to get everything they need without unwrapping to theFunctionData
. I also cleaned up some docs and tests that were outdated due to a VOM cost refactor. I didn't fix this failure, which I assume is due to changes elsewhere:Adding @kdayday as a reviewer of these added semantics:
get_slopes(::PiecewisePointwiseCurve)
calculates the slopes from the underlying pointwiseFunctionData
get_slopes(::PiecewiseIncrementalCurve)
fetches the slopes == the y-coordinates of the underlying stepFunctionData
get_average_rates(::PiecewiseAverageCurve)
fetches the average rates == the y-coordinates of the underlying stepFunctionData