Add some more PSY 3 -> PSY 4 system conversions #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
reviewed
Jun 21, 2024
| component["initial_storage_capacity_level"] = 0.0 | ||
| else | ||
| # Derive storage_capacity from old state of charge limits and normalize new | ||
| # state of charge limits, initial capacity accordingly |
There was a problem hiding this comment.
This is going to be dependent on the data that the user had and we have no way of knowing the prior assumptions. We should just throw a warning that we are doing the conversion.
There was a problem hiding this comment.
Added a warning.
jd-lara
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not because we've committed to providing these, but I wanted the converted version of a system anyway. Briefly ran the storage math by @rodrigomha but would appreciate a more formal review.