Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Base.@kwdef for compatibility with Julia versions below 1.9 #1168

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

sambuddhac
Copy link
Contributor

@sambuddhac sambuddhac commented Jul 31, 2024

Here is a short description:

  1. This PR fixes precompilation break by adding "import Base: @kwdef" in conjunction with the same fix for InfrastructureSystems.jl package (with a corresponding PR to that repo) for downward compatibility with Julia versions below 1.9.x
  2. My PR fixes issue Code not precompiling due to undefined "@kwdef" #1167

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (3a6b909) to head (c2bd586).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   84.75%   84.75%           
=======================================
  Files         182      182           
  Lines        8349     8349           
=======================================
  Hits         7076     7076           
  Misses       1273     1273           
Flag Coverage Δ
unittests 84.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/PowerSystems.jl 100.00% <ø> (ø)

@jd-lara
Copy link
Member

jd-lara commented Aug 2, 2024

I merged the IS version of this PR. We should approve and merge this one too.

Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambuddhac can you commit the import fix instead of the prefix fix here too?

…/PowerSystems.jl for downward compatibility with Julia v1.8.x and below
@sambuddhac sambuddhac changed the title Replaced @kwdef with Base.@kwdef since otherwise package errors Import Base.@kwdef for compatibility with Julia versions below 1.9 Aug 2, 2024
@GabrielKS GabrielKS self-requested a review August 2, 2024 16:18
@sambuddhac
Copy link
Contributor Author

@GabrielKS , just edited the header, description, and code modifications as per your suggestions. Thanks a lot !!! 👯‍♀️

@sambuddhac
Copy link
Contributor Author

I merged the IS version of this PR. We should approve and merge this one too.

Thanks tons, Jose @jd-lara !!! Yall are rock-stars !!!

@GabrielKS GabrielKS linked an issue Aug 2, 2024 that may be closed by this pull request
@GabrielKS
Copy link
Collaborator

For the record, this corresponds to NREL-Sienna/InfrastructureSystems.jl#390 in IS

Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielKS
Copy link
Collaborator

@jd-lara ready to release

@jd-lara jd-lara merged commit 6c55eb2 into NREL-Sienna:main Aug 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code not precompiling due to undefined "@kwdef"
3 participants