-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Base.@kwdef for compatibility with Julia versions below 1.9 #1168
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 182 182
Lines 8349 8349
=======================================
Hits 7076 7076
Misses 1273 1273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I merged the IS version of this PR. We should approve and merge this one too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sambuddhac can you commit the import fix instead of the prefix fix here too?
…/PowerSystems.jl for downward compatibility with Julia v1.8.x and below
@GabrielKS , just edited the header, description, and code modifications as per your suggestions. Thanks a lot !!! 👯♀️ |
Thanks tons, Jose @jd-lara !!! Yall are rock-stars !!! |
For the record, this corresponds to NREL-Sienna/InfrastructureSystems.jl#390 in IS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jd-lara ready to release |
Here is a short description: