Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Market Bid docs typos #1200

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Update Market Bid docs typos #1200

merged 2 commits into from
Oct 7, 2024
+6 −4

Conversation

rodrigomha
Copy link
Contributor

@rodrigomha rodrigomha commented Oct 7, 2024 •
edited by kdayday
Loading

closes #1187

@rodrigomha rodrigomha requested a review from kdayday October 7, 2024 19:27
@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (e5cf0c9) to head (8097e9b).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         181      181           
  Lines        8389     8389           
=======================================
  Hits         7091     7091           
  Misses       1298     1298
Flag Coverage Δ
unittests 84.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kdayday
Copy link
Contributor

kdayday commented Oct 7, 2024 •
edited
Loading

@rodrigomha Does this resolve #1187 ?

kdayday
kdayday approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@kdayday kdayday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rodrigomha
Copy link
Contributor Author

Yeah this should close that issue

@rodrigomha rodrigomha merged commit 9cbd729 into main Oct 7, 2024
10 of 11 checks passed
@rodrigomha rodrigomha deleted the rh/fix_market_bid_docs branch October 7, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdayday kdayday kdayday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: market bid example error
2 participants
@rodrigomha @kdayday