Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matpower base power parser #1218

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

rodrigomha
Copy link
Contributor

@rodrigomha rodrigomha commented Dec 9, 2024

Currently if data has 0 base power for units, the conversion default to NaN.

@rodrigomha rodrigomha requested a review from jd-lara December 9, 2024 21:58
@rodrigomha rodrigomha self-assigned this Dec 9, 2024
@rodrigomha rodrigomha changed the title Fix Matpower base power parser [WIP] Fix Matpower base power parser Dec 9, 2024
@rodrigomha rodrigomha changed the title [WIP] Fix Matpower base power parser Fix Matpower base power parser Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.29%. Comparing base (91bc0ab) to head (2d4b336).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/parsers/power_models_data.jl 56.52% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   84.35%   84.29%   -0.07%     
==========================================
  Files         181      181              
  Lines        8375     8391      +16     
==========================================
+ Hits         7065     7073       +8     
- Misses       1310     1318       +8     
Flag Coverage Δ
unittests 84.29% <56.52%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/parsers/power_models_data.jl 90.08% <56.52%> (-1.91%) ⬇️

@jd-lara jd-lara merged commit 03b9c17 into main Dec 10, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants