Variable Cost Refactor Part 1: Function Data #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Load and re-serialize systems, relying on PowerSystems' automatic conversion to bring them up to date - Replace each validation descriptors file with a fresh up-to-date version created by serializing a system from scratch
jd-lara
reviewed
Feb 17, 2024
|
The PSB tests now pass! A few more FunctionData replacements were necessary. IS, PSY, and PSB tests pass when using the appropriate branches of each plus PowerSystemsTestData: |
This was referenced Feb 22, 2024
|
The group of four PRs this is a part of: |
jd-lara
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I haven't gotten the PSB tests to pass yet, but I am pretty sure this is all the changes we'll need over here.