Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost Functions Refactor 2.1 #52

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Cost Functions Refactor 2.1 #52

merged 6 commits into from
Apr 30, 2024

Conversation

GabrielKS
Copy link
Contributor

GabrielKS added 6 commits April 2, 2024 19:01
@GabrielKS
Use new operational cost structs
70ab0f5
@GabrielKS
Remove more old costs
81539f4
@GabrielKS
Convert systems again to use updated costs
b8c323a 
 - Load and re-serialize systems again, relying on PowerSystems'
   automatic conversion to bring them up to date
 - Replace each validation descriptors file with a fresh up-to-date
   version created from `System(100.).data.validation_descriptors`
@GabrielKS
Make final cost adjustments to make tests pass
83135d5
@GabrielKS
Update type of bid cost
609588b
@GabrielKS
Use cost aliases
4aed821
@GabrielKS GabrielKS requested a review from jd-lara April 22, 2024 22:10
jd-lara
jd-lara approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests passed. The changes are too extensive for a line by line review

@jd-lara jd-lara merged commit 5a4d840 into psy4 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-lara jd-lara jd-lara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielKS @jd-lara