Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update index page #31

Merged
merged 42 commits into from
Dec 11, 2024
Merged

update index page #31

merged 42 commits into from
Dec 11, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Feb 7, 2024

More documentation updates

@jd-lara jd-lara added the documentation Improvements or additions to documentation label Feb 7, 2024
docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
@@ -29,7 +29,8 @@ DeviceModel(
)
```

Each formulation can have different implementations for these attributes and the details can be found in the Formulation Library section in the documentation.
!!! tip
Each formulation can have different implementations for attributes. Carefully review the formulation library pages to understand how to configure the storage model according to your requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
Each formulation can have different implementations for attributes. Carefully review the formulation library pages to understand how to configure the storage model according to your requirements
Each formulation can have different implementations for attributes. Carefully review the formulation library pages to understand how to configure the storage model according to your requirements

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.54%. Comparing base (676061f) to head (6541120).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   31.54%   31.54%           
=======================================
  Files           9        9           
  Lines         932      932           
=======================================
  Hits          294      294           
  Misses        638      638           
Flag Coverage Δ
unittests 31.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/StorageSystemsSimulations.jl 33.33% <ø> (ø)
src/core/variables.jl 33.33% <ø> (ø)

@@ -29,7 +29,9 @@ DeviceModel(
)
```

Each formulation can have different implementations for these attributes and the details can be found in the Formulation Library section in the documentation.
!!! tip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

@kdayday
Copy link
Contributor

kdayday commented Nov 1, 2024

@jd-lara Here are the docstrings needed in constraints.jl and variables.jl:

  • AncillaryServiceVariableDischarge
  • AncillaryServiceVariableCharge
  • StateofChargeLimitsConstraint
  • StorageCyclingCharge
  • StorageCyclingDischarge
  • ReserveCoverageConstraint
  • ReserveCoverageConstraintEndOfPeriod
  • ReserveCompleteCoverageConstraint
  • ReserveCompleteCoverageConstraintEndOfPeriod
  • StorageTotalReserveConstraint
  • ReserveDischargeConstraint
  • ReserveChargeConstraint

These constraints are not exported and also don't have docstrings. They don't show up in either the public or internal API. Should they be exported?

  • StateofChargeTargetConstraint
  • StorageRegularizationConstraintCharge
  • StorageRegularizationConstraintDischarge

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rodrigomha
Copy link
Collaborator

rodrigomha commented Nov 5, 2024

This PR should try to close #45 (if possible)
and also #34 (if possible)

@kdayday
Copy link
Contributor

kdayday commented Nov 5, 2024

This PR should try to close #45 (if possible) and also #34 (if possible)

Or these could be addressed as part of Anna's re-organization @annacasavant, in order to focus this on just getting running again

@kdayday
Copy link
Contributor

kdayday commented Dec 9, 2024

@jd-lara Here are the docstrings needed in constraints.jl and variables.jl:

* [ ]  AncillaryServiceVariableDischarge

* [ ]  AncillaryServiceVariableCharge

* [ ]  StateofChargeLimitsConstraint

* [ ]  StorageCyclingCharge

* [ ]  StorageCyclingDischarge

* [ ]  ReserveCoverageConstraint

* [ ]  ReserveCoverageConstraintEndOfPeriod

* [ ]  ReserveCompleteCoverageConstraint

* [ ]  ReserveCompleteCoverageConstraintEndOfPeriod

* [ ]  StorageTotalReserveConstraint

* [ ]  ReserveDischargeConstraint

* [ ]  ReserveChargeConstraint

These constraints are not exported and also don't have docstrings. They don't show up in either the public or internal API. Should they be exported?

* [ ]   StateofChargeTargetConstraint

* [ ]  StorageRegularizationConstraintCharge

* [ ]  StorageRegularizationConstraintDischarge

@jd-lara @rodrigomha @rafamonvar What's the status on getting these docstrings filled out? If you don't have availability, could of you share the Latex file with @annacasavant to finish this PR? Thanks!

@rodrigomha
Copy link
Collaborator

Just rebased with main. Documentation is compiling correctly locally using PowerSimulations main. We need to get a release for PowerSimulations that can use the new version of storage.

@jd-lara jd-lara merged commit 808b04d into main Dec 11, 2024
1 of 5 checks passed
@jd-lara jd-lara deleted the jd/fixdocsv3 branch December 11, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants