Skip to content

Commit

Permalink
Set g function ref ratio as radius over length.
Browse files Browse the repository at this point in the history
  • Loading branch information
joseph-robertson committed Sep 11, 2023
1 parent ff35611 commit cd5eb1a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>972718e7-19fc-4b8f-adc9-246916d17229</version_id>
<version_modified>2023-08-25T14:42:54Z</version_modified>
<version_id>9f0c57c4-a887-4b4a-bf50-90ba783b18d9</version_id>
<version_modified>2023-09-11T23:05:26Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -322,7 +322,7 @@
<filename>hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>63E26750</checksum>
<checksum>B86B4518</checksum>
</file>
<file>
<filename>hvac_sizing.rb</filename>
Expand Down
2 changes: 1 addition & 1 deletion HPXMLtoOpenStudio/resources/hvac.rb
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,10 @@ def self.apply_ground_to_air_heat_pump(model, runner, weather, heat_pump,
ground_heat_exch_vert.setUTubeDistance(UnitConversions.convert(heat_pump.geothermal_loop.shank_spacing, 'in', 'm'))
ground_heat_exch_vert.setPipeThickness(UnitConversions.convert((hp_ap.pipe_od - hp_ap.pipe_id) / 2.0, 'in', 'm'))
ground_heat_exch_vert.setMaximumLengthofSimulation(1)
ground_heat_exch_vert.setGFunctionReferenceRatio(0.0005)
ground_heat_exch_vert.setDesignFlowRate(UnitConversions.convert(hp_ap.GSHP_Loop_flow, 'gal/min', 'm^3/s'))
ground_heat_exch_vert.setNumberofBoreHoles(hp_ap.GSHP_Bore_Holes.to_i)
ground_heat_exch_vert.setBoreHoleLength(UnitConversions.convert(hp_ap.GSHP_Bore_Depth, 'ft', 'm'))
ground_heat_exch_vert.setGFunctionReferenceRatio(ground_heat_exch_vert.boreHoleRadius.get / ground_heat_exch_vert.boreHoleLength.get) # ensure this ratio is consistent with rb/H so that g values will be taken as-is
ground_heat_exch_vert.removeAllGFunctions
for i in 0..(hp_ap.GSHP_G_Functions[0].size - 1)
ground_heat_exch_vert.addGFunction(hp_ap.GSHP_G_Functions[0][i], hp_ap.GSHP_G_Functions[1][i])
Expand Down

0 comments on commit cd5eb1a

Please sign in to comment.