Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to *official* HPXML v4 schema #1490

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Updating to *official* HPXML v4 schema #1490

merged 6 commits into from
Sep 27, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Sep 26, 2023

Pull Request Description

Closes #1485.

Breaking changes:

A warning is provided if a portable spa is found in the HPXML, since we don't currently handle those inputs.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the hpxml label Sep 26, 2023
@shorowit shorowit added this to the 1.7.0 milestone Sep 26, 2023
@shorowit shorowit self-assigned this Sep 26, 2023
@shorowit shorowit marked this pull request as ready for review September 27, 2023 17:13
@shorowit shorowit merged commit 499fae7 into master Sep 27, 2023
5 checks passed
@shorowit shorowit deleted the hpxml_v4 branch September 27, 2023 21:17
@joseph-robertson joseph-robertson mentioned this pull request Oct 3, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update hot tub/spa inputs
1 participant