Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CFIS with PTHP/PTAC #1876

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Allow CFIS with PTHP/PTAC #1876

merged 6 commits into from
Nov 1, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 31, 2024

Pull Request Description

Closes #1029. Allows CFIS systems to be attached to, e.g., PTHPs and PTACs (by using a DSE=1 distribution system).

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Oct 31, 2024
@shorowit shorowit self-assigned this Oct 31, 2024
@shorowit shorowit marked this pull request as ready for review November 1, 2024 01:00
@shorowit shorowit merged commit 2f7c475 into master Nov 1, 2024
@shorowit shorowit deleted the pthp_cfis branch November 1, 2024 14:35
@joseph-robertson joseph-robertson mentioned this pull request Nov 5, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Additional CFIS capabilities/inputs
1 participant