Fix Warning #516

Fixes warning to 516 on performance and mismatch calculations trying to floatize a value that is actually a dataframe. Left it with a if statement in case a dictionary is passed directly (I think that's one of our cases... maybe... we'll see if the pytest breaks :D )
NREL · Jun 18, 2024 · a579479 · a579479
1 parent d906d3f
commit a579479
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 10 deletions.
diff --git a/bifacial_radiance/mismatch.py b/bifacial_radiance/mismatch.py
@@ -197,7 +197,10 @@ def mismatch_fit3(data):
     fit3 = 0.054*mad + 0.068*mad2
 
     if fit3.__len__() == 1:
-        fit3 = float(fit3)
+        if isinstance(fit3, pd.Series):
+            fit3 = float(fit3.iloc[0])
+        else:
+            fit3 = float(fit3)
 
     return fit3
 

diff --git a/bifacial_radiance/performance.py b/bifacial_radiance/performance.py
@@ -6,7 +6,7 @@
 """
 
 import pvlib
-
+import pandas as pd
 
 def calculatePerformance(effective_irradiance, CECMod, temp_air=None,
                          wind_speed=1, temp_cell=None,  glassglass=False):
@@ -57,17 +57,27 @@ def calculatePerformance(effective_irradiance, CECMod, temp_air=None,
                                                 temp_model_params['a'],
                                                 temp_model_params['b'],
                                                 temp_model_params['deltaT'])
-
+
+        if isinstance(CECMod, pd.DataFrame):
+            CECMod.to_pickle("CECMod.pkl")  
+            if len(CECMod) == 1:
+                CECMod1 = CECMod.iloc[0] 
+            else: 
+                print("More than one Module passed. Error, using 1st one")
+                CECMod1 = CECMod.iloc[0] 
+        else:
+            CECMod1 = CECMod
+
     IL, I0, Rs, Rsh, nNsVth = pvlib.pvsystem.calcparams_cec(
         effective_irradiance=effective_irradiance,
         temp_cell=temp_cell,
-        alpha_sc=float(CECMod.alpha_sc),
-        a_ref=float(CECMod.a_ref),
-        I_L_ref=float(CECMod.I_L_ref),
-        I_o_ref=float(CECMod.I_o_ref),
-        R_sh_ref=float(CECMod.R_sh_ref),
-        R_s=float(CECMod.R_s),
-        Adjust=float(CECMod.Adjust)
+        alpha_sc=float(CECMod1.alpha_sc),
+        a_ref=float(CECMod1.a_ref),
+        I_L_ref=float(CECMod1.I_L_ref),
+        I_o_ref=float(CECMod1.I_o_ref),
+        R_sh_ref=float(CECMod1.R_sh_ref),
+        R_s=float(CECMod1.R_s),
+        Adjust=float(CECMod1.Adjust)
         )
 
     IVcurve_info = pvlib.pvsystem.singlediode(