-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect simulation errors in results json #437
Conversation
"step_failures": [ | ||
{ | ||
"measure_dir_name": "BuildExistingModel", | ||
"step_errors": [ | ||
"Cannot find weather file at /var/simdata/openstudio/lib/resources/measures/HPXMLtoOpenStudio/resources/var/simdata/openstudio/weather/USA_TX_Houston-Bush.Intercontinental.AP.722430.epw." | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step_failures
entry is the only change to this file, other than unzipping it.
Minimum allowed coverage is Generated by 🐒 cobertura-action against f4a0503 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It's a good first step for doing #379.
Pull Request Description
Copy OpenStudio errors into each task's results json file, so they can more easily be summarized and surfaced after the job is complete. (We are viewing them from a python notebook that shows other summary statistics about a job.)
Example output for one simulation (error caused by a mismatch in package version numbers):
Also, unzip the test file
results_job1.json.gz
to make it human-readable. (It's un-zipped before being used in the test anyway.)Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentation