-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply shared water heater to whole building #1121
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3bde820 ecdfd3bde820 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 7823911ce250 Latest results. af530fec35cc Fix unit multiplier tests for PV, generators, and mech vent. 01b292fccbe4 Latest results. 01b6e96fbdb4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier f1da02990a8c Add tests that compare results of sample files against the same sample files with a 10x unit multiplier. Fix unit multiplier for more building components. 129f367c92e9 Need to ignore shading_id attrs. ff3aed82522a Remove debug line. b0430c9f7690 Validate files created in build measure tests. 8c95d15f6923 Handle all buildings from workflow tests. 8ceda701c43a Set unit_model on schedules_file instance. 692f9aeed65f Avoid hardset of site id and shading ids. 50b4970af382 Remove clothes dryer from first building in sample file. 2590ba7ad7c3 Try multiple buildings with detailed schedules. 989255809956 Avoid duplicating bill scenarios. d05086b64adb Make SiteID variable to avoid overwriting it. ec313d7fb8d1 Update sample files. 9cd85ce62e14 Update build measure to add buildings to existing hpxml file. 89732f2cb8a5 Small bugfix [ci skip] d4af087d88ce Update ReportSimulationOutput so that more outputs are for the whole MF building. Still need to fix and double-check some things. 0d61bd1a0a0a Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 77c49d4edd51 Fix CI failure. e347a970d7b6 Latest results. 93b757ce2eba Update in.xml to reflect the entire HPXML file when using `-b ALL`. Let's see what breaks... d6c8a73ec28f Fix a couple more tests. 88626d65d5fd Fix lots of CI tests 3ca3daaf7725 Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier f8616b21b739 First pass on expanding HPXML class to support multiple HPXML Building elements. Not everything works yet, but many things do. 16acfc6cf26f Latest results. ef3e4c470b52 Bugfixes. 9501aef17543 Fix possibility of missing tmains schedule. Fix boiler pump energy. 83da1fc485e2 Improve water heating and tank losses 712883a30244 Merge bugfixes. 02905d38b8d3 Address heat pump backup. c731a179cf0a Merge branch 'unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier c5ad64cdea43 Fix CI failures. b99c32cef07a Bugfix. 9b4f957fa96c Fix water heater EC adjustment and boiler pilot light. 4e7d16abec14 Progress on appliances, lighting, water heating, component loads. Fix cooling. 8b64ec6a74aa Apply it to all thermal zones (probably doesn't matter for unconditioned zones, but matters for duct zones). efe6d818e251 Step 1: Use E+ zone multiplier. 0534a62ff162 Fix CI error with a different hack. 2fe693ac9ba3 Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 2c1ffcb1cb5c Fixes CI tests 1d41b521eadd Some runtime improvements. f1839d16241e Latest results. b15d861d800d Prevent overeager EMS renaming related to 'foo' and 'foo_1'. feb60267dc42 Fix typo. 7b100bd1f4b2 Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 07f0ae43eded Avoid using object names to infer the building feature. Other misc cleanup. ce90c7e5222c Latest results. f29e242ab6e4 Latest results. a024f270c859 Bugfix for no ducts. cf7820ed1b60 Bugfix for loads calculation when there are multiple duct zones. 019df591dbf8 Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 9ad2cbfa49fd Fix unmet hours. 1879b8d2bb52 Latest results. 09abfa44f517 Bugfix. 6399212aa8df Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models cbb8ff9be07f Bugfix. e84462498979 Address total loads, component loads, and unmet hours outputs for whole-building models. 42363adc59a7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 22efeb8794b8 Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models feaad3e9d635 Port over unit geometry shifting. 834961bb36cc Latest results. fd5ca970ed4f Fix CI tests, maybe. 6e8523fdb4d1 Bugfix; only process weather once for faster performance. 1cfeb80e2d79 First pass on being able to simulate whole SFA/MF buildings using code prototyped in URBANopt. git-subtree-dir: resources/hpxml-measures git-subtree-split: ecdfd3bde820cfdd1a74c517f12131b4c9673764
Currently seeing the following error, e.g., for national project's building ID=17:
|
shorowit
reviewed
Aug 21, 2023
6ed0c43308 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 0dd6be8bda Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 0f80b93a49 Merge pull request #1467 from NREL/build-res-validation 4de9a0a6f3 Another remove. 7fb1dfc97e Remove checks for bad duct defaults. 8dbaf08de7 Merge branch 'master' into build-res-validation 7b8cd4df3e Update the changelog. [ci skip] 9b51701f0e Clean up test file. 31931317b8 Catch errors for certain duct surface area arg combos. 1d968719b9 Add test for demonstrating invalid defaults. 213e506092 Must write defaulted hpxml_doc before validating. 8212560c97 Update apply_validation arg in build test file. 5429fbd508 Change behavior of apply_defaults and apply_validation. a4072e7562 Add extra build measure tests. ecdfd3bde8 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 7823911ce2 Latest results. af530fec35 Fix unit multiplier tests for PV, generators, and mech vent. 01b292fccb Latest results. 01b6e96fbd Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier f1da02990a Add tests that compare results of sample files against the same sample files with a 10x unit multiplier. Fix unit multiplier for more building components. 129f367c92 Need to ignore shading_id attrs. ff3aed8252 Remove debug line. b0430c9f76 Validate files created in build measure tests. 8c95d15f69 Handle all buildings from workflow tests. 8ceda701c4 Set unit_model on schedules_file instance. 692f9aeed6 Avoid hardset of site id and shading ids. 50b4970af3 Remove clothes dryer from first building in sample file. 2590ba7ad7 Try multiple buildings with detailed schedules. 9892558099 Avoid duplicating bill scenarios. d05086b64a Make SiteID variable to avoid overwriting it. ec313d7fb8 Update sample files. 9cd85ce62e Update build measure to add buildings to existing hpxml file. 89732f2cb8 Small bugfix [ci skip] d4af087d88 Update ReportSimulationOutput so that more outputs are for the whole MF building. Still need to fix and double-check some things. 0d61bd1a0a Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 77c49d4edd Fix CI failure. e347a970d7 Latest results. 93b757ce2e Update in.xml to reflect the entire HPXML file when using `-b ALL`. Let's see what breaks... d6c8a73ec2 Fix a couple more tests. 88626d65d5 Fix lots of CI tests 3ca3daaf77 Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier f8616b21b7 First pass on expanding HPXML class to support multiple HPXML Building elements. Not everything works yet, but many things do. 16acfc6cf2 Latest results. ef3e4c470b Bugfixes. 9501aef175 Fix possibility of missing tmains schedule. Fix boiler pump energy. 83da1fc485 Improve water heating and tank losses 712883a302 Merge bugfixes. 02905d38b8 Address heat pump backup. c731a179cf Merge branch 'unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier c5ad64cdea Fix CI failures. b99c32cef0 Bugfix. 9b4f957fa9 Fix water heater EC adjustment and boiler pilot light. 4e7d16abec Progress on appliances, lighting, water heating, component loads. Fix cooling. 8b64ec6a74 Apply it to all thermal zones (probably doesn't matter for unconditioned zones, but matters for duct zones). efe6d818e2 Step 1: Use E+ zone multiplier. 0534a62ff1 Fix CI error with a different hack. 2fe693ac9b Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 2c1ffcb1cb Fixes CI tests 1d41b521ea Some runtime improvements. f1839d1624 Latest results. b15d861d80 Prevent overeager EMS renaming related to 'foo' and 'foo_1'. feb60267dc Fix typo. 7b100bd1f4 Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 07f0ae43ed Avoid using object names to infer the building feature. Other misc cleanup. ce90c7e522 Latest results. f29e242ab6 Latest results. a024f270c8 Bugfix for no ducts. cf7820ed1b Bugfix for loads calculation when there are multiple duct zones. 019df591db Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 9ad2cbfa49 Fix unmet hours. 1879b8d2bb Latest results. 09abfa44f5 Bugfix. 6399212aa8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models cbb8ff9be0 Bugfix. e844624989 Address total loads, component loads, and unmet hours outputs for whole-building models. 42363adc59 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models 22efeb8794 Merge branch 'whole_sfa_mf_models' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models feaad3e9d6 Port over unit geometry shifting. 834961bb36 Latest results. fd5ca970ed Fix CI tests, maybe. 6e8523fdb4 Bugfix; only process weather once for faster performance. 1cfeb80e2d First pass on being able to simulate whole SFA/MF buildings using code prototyped in URBANopt. git-subtree-dir: resources/hpxml-measures git-subtree-split: 6ed0c433084ff1c0784f3ee46a20ebacd3d5483f
…08b5f 255fa708b5f Merge pull request #1457 from NREL/build_whole_sfa_mf_models_unit_multiplier 807e7465c70 Few review items. 3a8d55b5547 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 3682e332fe8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 7edc02eaf93 Merge pull request #1489 from NREL/resilience_battery_losses 1237e529ff6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into resilience_battery_losses fe46a5e09f8 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 4ee7943a3aa Latest results. b63b0b8e6a6 Latest results. da13ed33f68 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 340080c2be5 Fix CI failure 0c8459b1d53 Bugfix. e8084e0c175 Bugfix. bad31f76df9 Bugfix. 4fc424efb03 Revert. 6ff05d83158 Add error-messages around building features that are not supported. Re-enable more tests. b97017bd50c Change a value for bad emissions scenario file. 72332831c79 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 0c7f5957cf4 Allow emissions same name but different type. 5bd86227061 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 4902b2839b6 Update same emissions scenario name in sample file. ed024c39afb Merge pull request #1491 from NREL/hpxml_v4_conditioned_space 3e857ce84ed Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hpxml_v4_conditioned_space 7f6a43b6e9a Update logic for catching header issues. 499fae75715 Merge pull request #1490 from NREL/hpxml_v4 6bee34ee7c3 Possible merge conflict in tasks.rb. 17ce9978ee6 Refactor error checking on hpxml header inputs. f974b29c52d Merge branch 'hpxml_v4' of https://github.com/NREL/OpenStudio-HPXML into hpxml_v4 6d171e75fa9 Add warning for portable spas; move other warnings from ruby to schematron. Add tests. 777c469605b Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier e9f3c2c1f01 Latest results. 5205e1889d9 Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier b101c77b6cc Bugfix. 8a185d891a7 Latest results. f1a03366f25 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 88f797203d9 Fix tests. 2934a76aba7 Latest results. 8c857a758b6 Latest results. f2377cb0ee2 Update project URL [ci skip] cc8369bf2a2 Rename [ci skip] 9ec8f423f1c Automatically add issues to project board. [ci skip] 1c29c0f7f32 Merge branch 'hpxml_v4' of https://github.com/NREL/OpenStudio-HPXML into hpxml_v4_conditioned_space 4450d6fd7c4 Missed one file 9b4a761d77f Moves some elements from SoftwareInfo/extension to BuildingDetails/BuildingSummary/extension to allow variation across MF dwelling units. 7e85203caeb Fix CI failure. 1606aa31c86 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier a4280a1b042 Merge branch 'hpxml_v4' of https://github.com/NREL/OpenStudio-HPXML into hpxml_v4_conditioned_space e9f95ae0c7d Fix CI failures. 2d79faf67d4 First cut at errors for conflicting header or building inputs. 67c0e2efc01 First pass on using "conditioned space" instead of "living space" 8e40cee43b9 First pass on updating to official HPXML v4 schema. a28777224db Clarify new argument and add more description. 27c8a79b1b1 Clarify test. 4fb3faf3905 Merge branch 'build_whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into build_whole_sfa_mf_models_unit_multiplier e8c49e0f859 Remove need for base-two-buildings files and call BuildResidentialScheduleFile once for each building unit. 0b604eb8f71 Revert comment. [ci skip] c6fe8903fc8 Merge pull request #1486 from NREL/dfhp_sizing_docs c407654cd5e Clean up. ec6519a385c Add comment about deleting extra SchedulesFilePath. [ci skip] 10170eb1cb0 Regenerate both schedule files from new sample file. becc012fcb9 Actually add two buildings sample file with different detailed schedules. 7a95206671c Create a new sample file of two buildings having separate detailed schedules. 143583f80fa Update changelog [ci skip] d9d57f6578c Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 36c3b083765 Merge pull request #1478 from NREL/whole_sfa_mf_models_unit_multiplier_schedules 09097cd83ca Latest results. c68cd4de434 Bugfix. 0504e746628 Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier_schedules aaabb6922a9 Remove obsolete code. 00a53dc1f9f Remove battery losses EMS output var and use other equipment object directly. 927ff665efe Fix cases w/o batteries. f12b1b4cfac Fixes battery resilience output so that it includes battery losses. 449e690b705 Latest results. 4b6e05d75d3 Few more updates for the deprecation. 998b658ea19 Deprecate hpxml header location of SchedulesFilePath. 98d91cf8a65 Respond to review comments. 2d3e5b12a6f Update validator and ruby error messages test. 693c7aa5f42 Update docs and epvalidator. 6b099bad0ab A little cleanup. 78e37b5425d Document autosizing methodology for e.g. dual-fuel HPs. 816536fe0da Few fixes in build schedule file tests. 4d28cc0b0cb Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier d1dd11fb313 Merge branch 'whole_sfa_mf_models_unit_multiplier' into whole_sfa_mf_models_unit_multiplier_schedules d8c2883bce7 Does this help? d76e39f3b9b Probably won't help, but no need for these to be global vars d10f149d20c More debugging 46fb2cf20fe Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier d4e9fc6e428 More debugging c54d757fab8 Latest results. c361087badc Revert to OS 3.6.1; trying tests w/o parallelization 601d0c9a220 Update for OS develop a51d78e1598 Resolve merge 0978d7dd4c0 Update for OS develop af8081eda0b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 696eef19e6d Try develop c28a3a350f1 Merge pull request #1483 from NREL/misc-cleanup ee18aabdc5f A little more debug 77bdf2d4c9a Debug 565a6f027a2 Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier f6f2ec45289 Revert to full tests fc8db4b921c Latest results. c8a2b3a09b0 Improve stratified tank UA calc. Some refactoring of schedules to reduce global variables and avoid a ScheduleFiles::set_unit_model method. cfcbf6bcefc Fix CI? d4c2452d572 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 9002ccd9a90 More progress on DHW. Stratified tank (non-HPWH) and solar test files now pass. 57b77b914db We shouldn't set a default value for an optional argument, as we want the OS-HPXML default (downstream) to be used. 1278ca1c036 Set idref to nil on cw and dw when wh is deleted. 6086d84d8ee Remove unused array in build measure. 369eda63ac2 Merge pull request #1480 from NREL/hpxml_sync 0a1ea17e995 Sync w/ hpxmlwg repo 5ce28171454 Add error message 5180896badc Update `HPXML::has_fuel` method to work with multiple Buildings 50a2293b6b5 Latest results. 1a21f2e7b97 Some code cleanup/simplification. 32e5d6cb81f Merge branch 'whole_sfa_mf_models_unit_multiplier' into whole_sfa_mf_models_unit_multiplier_schedules f8082a6b20c Append in.schedules.csv int only for 2+ buildings. 33635792394 Add error-checking if unique objects have different values across dwelling units. 7b84afcccad Merge branch 'whole_sfa_mf_models_unit_multiplier' into whole_sfa_mf_models_unit_multiplier_schedules fced7235737 Updates for schedules filepath backward compatibility. 3858f3940c5 Attempt to address meta_measure.rb FIXME 0ff590cc488 Carry building_id to schedule file measure in run_simulation.rb. 6b46d321b83 Updates for bldg header and schedule variation across units. 3612308b82e Merge branch 'whole_sfa_mf_models_unit_multiplier' into whole_sfa_mf_models_unit_multiplier_schedules 966a5a69912 Update schedules and validation test files. 11f5ffa33cd Update expected warning bbc25749e1b This FIXME has been addressed. e9e7595c35f Provide a warning when NumberofUnits is greater than 1 04a9d186eb7 Revert removal of the unit_model workaround. 74ad7beb6e4 Introduce new building_id argument and test it. 0e0978686fb Updates to schedule file measure for multiple buildings. 3608f7ef79b Update build schedule file measure and tests. 039b9acc475 Regenerate all sample files with schedules filepath. 64df290a544 Update build measure to write building level schedules filepath. bb6995a02e7 Create class for schedules filepath at building level. 179eb3a6a77 Latest results. fca555c8368 Exclude file w/ battery. 398a0792270 Add timeseries test asserts for 1x vs 10x results. d395572ae45 Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 8e9a50696dd Timeseries airflow outputs now work. dbf8fbe02a7 Latest results. 9daa31e673b Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 8c4a1b03955 Enable more test files. 61f1a57ff47 Latest results. 808381f7661 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier bdbcddd1d6d Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 6f32530cf4a Enable more test files. 379d9e765eb Latest results. f3521172144 Fix CI error; this seems to be a better solution than the previous hack. d64bf86a9a2 Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 4fd2701e4f7 Misc updates to docs. 70029045cf5 Latest results. 81ebbc6f48b Address duct losses. d9fc66acc53 Address GSHPs a97a58c10cf Latest results. 1c2ef6dffff Skip another battery file. 2c4f0ecaba8 Fix CI failure 2109812b489 Update HPXMLs 34249402dab Exclude batteries for now. da32377dcb2 Some code cleanup and minor bugfixes. 6e49026dbb2 Increase unit model shift to reduce possibility of shading 18f32ca6a4a Bugfix. 22ed937b976 Avoid setting unique ids on the first building element. 97b09ec628e Merge branch 'whole_sfa_mf_models_unit_multiplier' into build_whole_sfa_mf_models_unit_multiplier 686567ad5f5 Backport Joe's bugfix. 1bc97a11391 Fix CI error. 8bb3af6888e Latest results. 21c1d9f3238 More advanced stress test. Rather than running the one HPXML Building with a 10x multiplier, we create two identical Buildings, each with a 5x multiplier. e7014938c92 Merge branch 'whole_sfa_mf_models_unit_multiplier' of https://github.com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier 0bb3503b460 Oops. 25b3d9ee479 Latest results. 581ff502289 Address unit multiplier for batteries. 867d244aebb Fix merge. git-subtree-dir: resources/hpxml-measures git-subtree-split: 255fa708b5fa6163b6eff6933a062fba86c7515a
Testing TODOs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Use the
BuildExistingModel
(andApplyUpgrade
) meta measure to create HPXML files with (optionally) number ofBuilding
elements equal to the maximum ofgeometry_building_num_units
and 5. All units (i.e., HPXMLBuilding
elements) are the same, except for stochastic schedules. The goals are to:geometry_building_num_units
is greater than 5)geometry_building_num_units
downstreamQuestions:
HeatPumpAirToWaterFuelFiredHeating
objects go on the supply side of the Heat Pump Loop?n_units
behpxml.buildings.size
(i.e., what is actually modeled) or should it be the number of units in the actual buildings?l_bldg
for the calculation of pipe supply/return length?Checklist
Not all may apply:
openstudio tasks.rb update_measures
has been run