Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign detailed schedules using the lookup #1166

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Assign detailed schedules using the lookup #1166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62cdf44
Add resstock arguments for various detailed schedules.
joseph-robertson Nov 14, 2023
cd3dde0
Assign detailed battery schedule for one existing option.
joseph-robertson Nov 14, 2023
38b138a
Force add the new schedule_files folder.
joseph-robertson Nov 14, 2023
61bc131
Merge branch 'develop' into enable-detailed-schedules
joseph-robertson Jul 29, 2024
843951b
Add other detailed schedule arguments to ignore list.
joseph-robertson Jul 29, 2024
444ca87
Refactor assignment of schedule arguments.
joseph-robertson Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add resstock arguments for various detailed schedules.
  • Loading branch information
@joseph-robertson
joseph-robertson committed Nov 14, 2023
commit 62cdf44afc6a23f7e316432c4cf3eb58ce25b305
43 changes: 43 additions & 0 deletions measures/ResStockArguments/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,26 @@ def arguments(model)
arg.setDescription('Whether the heat pump uses the existing system as backup.')
args << arg

arg = OpenStudio::Measure::OSArgument.makeStringArgument('heating_setpoint_schedule', false)
arg.setDisplayName('Heating Setpoint: Schedule CSV File Path')
arg.setDescription('Absolute/relative path of csv file containing user-specified detailed heating setpoint schedule.')
args << arg

arg = OpenStudio::Measure::OSArgument.makeStringArgument('cooling_setpoint_schedule', false)
arg.setDisplayName('Cooling Setpoint: Schedule CSV File Path')
arg.setDescription('Absolute/relative path of csv file containing user-specified detailed cooling setpoint schedule.')
args << arg

arg = OpenStudio::Measure::OSArgument.makeStringArgument('water_heater_setpoint_schedule', false)
arg.setDisplayName('Water Heater Setpoint: Schedule CSV File Path')
arg.setDescription('Absolute/relative path of csv file containing user-specified detailed water heater setpoint schedule.')
args << arg

arg = OpenStudio::Measure::OSArgument.makeStringArgument('battery_schedule', false)
arg.setDisplayName('Battery: Schedule CSV File Path')
arg.setDescription('Absolute/relative path of csv file containing user-specified detailed battery schedule.')
args << arg

return args
end

Expand Down Expand Up @@ -731,6 +751,29 @@ def run(model, runner, user_arguments)
end
args[:rim_joist_assembly_r] = rim_joist_assembly_r

# Detailed Schedules
schedules_filepaths = []

if args[:heating_setpoint_schedule].is_initialized
schedules_filepaths << args[:heating_setpoint_schedule].get
end

if args[:cooling_setpoint_schedule].is_initialized
schedules_filepaths << args[:cooling_setpoint_schedule].get
end

if args[:water_heater_setpoint_schedule].is_initialized
schedules_filepaths << args[:water_heater_setpoint_schedule].get
end

if args[:battery_schedule].is_initialized
schedules_filepaths << args[:battery_schedule].get
end

if !schedules_filepaths.empty?
args[:schedules_filepaths] = schedules_filepaths.join(',')
end

args.each do |arg_name, arg_value|
begin
if arg_value.is_initialized
Expand Down
60 changes: 57 additions & 3 deletions measures/ResStockArguments/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,21 @@
<schema_version>3.1</schema_version>
<name>res_stock_arguments</name>
<uid>c984bb9e-4ac4-4930-a399-9d23f8f6936a</uid>
<version_id>0f7806f4-076e-4db7-a108-a92a13539218</version_id>
<version_modified>2023-10-10T21:15:02Z</version_modified>
<version_id>621b9745-cba5-4524-adca-a511df21411c</version_id>
<version_modified>2023-11-14T21:08:27Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>ResStockArguments</class_name>
<display_name>ResStock Arguments</display_name>
<description>Measure that pre-processes the arguments passed to the BuildResidentialHPXML and BuildResidentialScheduleFile measures.</description>
<modeler_description>Passes in all arguments from the options lookup, processes them, and then registers values to the runner to be used by other measures.</modeler_description>
<arguments>
<argument>
<name>existing_hpxml_path</name>
<display_name>existing_hpxml_path</display_name>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>schedules_filepaths</name>
<display_name>schedules_filepaths</display_name>
Expand Down Expand Up @@ -146,6 +153,13 @@
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>unit_multiplier</name>
<display_name>unit_multiplier</display_name>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>geometry_unit_type</name>
<display_name>Geometry: Unit Type</display_name>
Expand Down Expand Up @@ -4660,6 +4674,14 @@
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>building_id</name>
<display_name>BuildingID</display_name>
<description>The ID of the HPXML Building. Only required if there are multiple Building elements in the HPXML file. Use 'ALL' to apply schedules to all the HPXML Buildings (dwelling units) of a multifamily building.</description>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>geometry_unit_cfa_bin</name>
<display_name>Geometry: Unit Conditioned Floor Area Bin</display_name>
Expand Down Expand Up @@ -5138,6 +5160,38 @@
</choice>
</choices>
</argument>
<argument>
<name>heating_setpoint_schedule</name>
<display_name>Heating Setpoint: Schedule CSV File Path</display_name>
<description>Absolute/relative path of csv file containing user-specified detailed heating setpoint schedule.</description>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>cooling_setpoint_schedule</name>
<display_name>Cooling Setpoint: Schedule CSV File Path</display_name>
<description>Absolute/relative path of csv file containing user-specified detailed cooling setpoint schedule.</description>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>water_heater_setpoint_schedule</name>
<display_name>Water Heater Setpoint: Schedule CSV File Path</display_name>
<description>Absolute/relative path of csv file containing user-specified detailed water heater setpoint schedule.</description>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>battery_schedule</name>
<display_name>Battery: Schedule CSV File Path</display_name>
<description>Absolute/relative path of csv file containing user-specified detailed battery schedule.</description>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
</arguments>
<outputs />
<provenances />
Expand All @@ -5161,7 +5215,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>EE32E37A</checksum>
<checksum>F5547CB6</checksum>
</file>
<file>
<filename>constants.rb</filename>
Expand Down
10 changes: 2 additions & 8 deletions measures/UpgradeCosts/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>upgrade_costs</name>
<uid>ef51212c-acc4-48d7-9b29-cf2a5c6c4449</uid>
<version_id>b7e23fcc-8201-463f-bb3b-cb6c5d2b15ef</version_id>
<version_modified>2023-11-08T14:37:22Z</version_modified>
<version_id>29804957-2795-4043-9d30-828aba72695d</version_id>
<version_modified>2023-11-14T21:08:27Z</version_modified>
<xml_checksum>9BF1E6AC</xml_checksum>
<class_name>UpgradeCosts</class_name>
<display_name>Upgrade Costs</display_name>
Expand Down Expand Up @@ -173,12 +173,6 @@
<usage_type>test</usage_type>
<checksum>BD0C91AB</checksum>
</file>
<file>
<filename>SFD_2story_FB_UA_GRG_GSHP_ElecTanklessWH.xml</filename>
<filetype>xml</filetype>
<usage_type>test</usage_type>
<checksum>12672F1D</checksum>
</file>
<file>
<filename>SFD_2story_PB_UA_ElecFurnace_ElecTankWH.osw</filename>
<filetype>osw</filetype>
Expand Down