Add facility to proposal model #139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunAishima
reviewed
Jan 30, 2025
JunAishima
approved these changes
Jan 31, 2025
|
Can you please test this? Otherwise it might be a while before I have time to test this fully. Adding a facility changes the data model and the assumed / implied data relationship that the facility name is associated with the proposal via the resource/beamline/instrument I'm not sure how this would work with multi-facility proposals - which we don't have many, but they do exist in theory. |
|
@stuartcampbell Should we instead infer the facility using the instrument list - would that be a preferred approach? I was not aware of this implicit relationship. Trying to follow existing conventions, but figuring it out in realtime. I believe there are still places where we need to address the multi-facility case besides this PR, however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
/proposalsendpoint does not actually respect the facility query parameter. This PR adds a facility field to the proposal data model and syncs this field when proposals are "cached" from PASS. Furthermore, the proposal fetching mechanism is updated to also query based on facility.This is not tested.