Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEA: merge recent fixes and updates #54

Merged
merged 35 commits into from
Nov 8, 2022
Merged

SEA: merge recent fixes and updates #54

merged 35 commits into from
Nov 8, 2022

Conversation

aromanielloNTIA
Copy link
Member

jhazentia and others added 30 commits May 4, 2022 15:52
@jhazentia
replace dateutil isoparse with datetime.fromisoformat, remove python-…
60e8b1f 
…dateutil dependency, update dependencies, fix django version for dependabot alert, set scos-actions version 1.0.1
@jhazentia
revert to using python-dateutil
41efbc1
@jhazentia
test_survey_iq_action
d814679
@jhazentia
Merge branch 'master' of https://github.com/NTIA/scos_actions into fi…
8e6c654 
…x_dateutil_dependency
@jhazentia
increment version to 2.0.1
4a2879e
@jhazentia
update dependencies, python3.8 minimum, update pre-commit
a728a76
@jhazentia
updated sigmf dependency
142a87e
@jhazentia
update dependencies, fix dependabot alert
7cc2c97
@jhazentia
add 739MHz to sensor example cal file
a19b685
@jhazentia
create script to add interpolated sections to cal files
93c0bdf
@jhazentia
add interpolated values to example cal files for usrp 700MHz actions,…
20fe676 
… remove scripts
@jhazentia
Merge branch 'master' of https://github.com/NTIA/scos-actions into fi…
d3e01ca 
…x_dateutil_dependency
@jhazentia
Merge branch 'master' of https://github.com/NTIA/scos-actions into fi…
ef8d84b 
…x_dateutil_dependency
@jhazentia
update sigmf branch
ab17d1c
@jhazentia
Merge branch 'master' of https://github.com/NTIA/scos-actions into fi…
f632247 
…x_dateutil_dependency
@jhazentia
update sample_debug for latest changes
7297c19
@jhazentia
add classification to survey action config
f9cf2be
@jhazentia
Merge branch 'fix_dateutil_dependency' of https://github.com/NTIA/sco…
7aadcb0 
…s-actions into fix_dateutil_dependency
@jhazentia
fix mock gps circular import
5c7b31e
@jhazentia
fix merge error
5aea3c0
@dboulware
Move signals to scos_actions and ran pre-commit.
22f11f4
@jhazentia
Merge pull request #47 from NTIA/circular_fix
f826372 
Move signals to scos_actions and ran pre-commit.
@jhazentia
switch SigMF back to multi-recording-archive branch
32e2960
@jhazentia
address review feedback, add warning message when using mocks
a64d79a
@aromanielloNTIA
Modify dependency handling for running tests
2623732
@aromanielloNTIA
Allow captures to start at nonzero sample indices
475d460
@aromanielloNTIA
Parameterize axis for apply_detector
7a2d6b4
@aromanielloNTIA
Increment version to 4.0.2
bf4418f
@jhazentia
Merge pull request #48 from NTIA/fix_dateutil_dependency
2cb403c 
Fix circular import, add test survey action, add interpolated values to calibration files
@aromanielloNTIA
Group tox with test dependencies
2a9358e
@aromanielloNTIA aromanielloNTIA added the enhancement New feature or request label Nov 7, 2022
@aromanielloNTIA aromanielloNTIA added this to the sea-prototype-v0.2 milestone Nov 7, 2022
@aromanielloNTIA aromanielloNTIA self-assigned this Nov 7, 2022
@aromanielloNTIA aromanielloNTIA changed the title Sea merge recent fixes SEA: merge recent fixes and updates Nov 7, 2022
@aromanielloNTIA aromanielloNTIA linked an issue Nov 7, 2022 that may be closed by this pull request
Apply circular import fixes in SEA data product #52
Closed
jhazentia
jhazentia approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@jhazentia jhazentia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Recommend to verify calibration data being used is within expectations when example calibration files are not being used (verify calibration data not from example files).

@aromanielloNTIA
Copy link
Member Author

aromanielloNTIA commented Nov 8, 2022 •
edited
Loading

Looks good to me. Recommend to verify calibration data being used is within expectations when example calibration files are not being used (verify calibration data not from example files).

I verified using the seadog01 sensor that this behaves as expected: when no calibration action is run, the calibration data is pulled from the sensor_calibration.json file supplied in SCOS Sensor. The example files included in scos_actions and scos_tekrsa are not used in this case. So, the user must either supply valid calibration files on sensor deployment, or run calibration actions to overwrite the files.

Edit: Running those tests led me to open this scos-sensor PR.

@aromanielloNTIA aromanielloNTIA merged commit c622ad5 into nasctn-sea Nov 8, 2022
@aromanielloNTIA aromanielloNTIA deleted the sea-merge-recent-fixes branch November 8, 2022 20:39
@aromanielloNTIA aromanielloNTIA mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhazentia jhazentia jhazentia approved these changes

Assignees

@aromanielloNTIA aromanielloNTIA

Labels
enhancement New feature or request
Projects
None yet
Milestone
sea-prototype-v0.2
Development

Successfully merging this pull request may close these issues.

Apply circular import fixes in SEA data product
3 participants
@aromanielloNTIA @jhazentia @dboulware