Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Docker Compose configuration entirely with environment variables #282
base: master
Are you sure you want to change the base?
Handle Docker Compose configuration entirely with environment variables #282
Changes from 26 commits
229281a
ee3b311
645b034
027b572
4814833
d3c541b
c795c98
d62ed2d
340588c
5aa2503
5875313
d804d6d
c01814a
e4f343d
80e4bd1
4e55d69
eb178f7
b9c5bf9
e29e015
e6fd715
aca1017
82bc5ed
df2e1dc
37cc54c
2f26795
58612f6
dab8607
cc553d0
16b12dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this would work if the SSD_DEVICE is a SATA device which is then mapped to an nvme device in the container? Perhaps it would be better to use ${SSD_DEVICE} for both then pass the SSD_DEVICE environment variable to scos-actions to get the path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command isn't returning anything on the sensors or my laptop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with a plaintext default value which can be changed when configuring a sensor.
Note also that I made changes in scos-actions (NTIA/scos-actions#126) which will result in a default value of
/dev/nvme0n1
being used by the SEA action if the environment variable is not provided.