This repository has been archived by the owner on Dec 27, 2017. It is now read-only.
navbar #7
Closed
navbar #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple issues:
<body>
<div class="container">
// original body contents
</div>
</body>Thanks for the work so far! |
| @@ -3,11 +3,62 @@ | |||
| <head> | |||
| <title>Academics | NUS Computing</title> | |||
| <link rel="stylesheet" href="assets/css/bootstrap.css"> | |||
| <link rel="stylesheet" href="assets/css/stylesheet.css"> | |||
| <link rel="shortcut icon" type="image/x-icon" href="assets/img/favicon.ico"> | |||
| <script src="assets/js/bootstrap.js"></script> | |||
There was a problem hiding this comment.
since we are serving the js from a CDN, you can remove this line
| @@ -3,11 +3,62 @@ | |||
| <head> | |||
| <title>Academics | NUS Computing</title> | |||
There was a problem hiding this comment.
Add the following lines above the <title> tag
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />This will show the mobile view on mobile sized screens (right now it doesn't work that well)
|
So far so good, the desktop view looks good. Just one more correction However the mobile view is not that great. The top bar elements are all misaligned. This is because they are in their own divs. For prototype purposes, we'll pull this in. When we decide on the actual framework, then we'll work on the mobile view again. @kennho Any thoughts? Else I'll merge it after the corrections are made |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2