Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Schema class to use better-proto for IO #3

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Conversation

karlhigley
Copy link
Contributor

This takes the Schema class (originally from NVT) and swaps the read/write functionality for importing/exporting Tensorflow Metadata protobuf files over to better-proto, but without coupling the Schema class directly to the file format.

@karlhigley karlhigley self-assigned this Feb 5, 2022
@karlhigley karlhigley requested a review from benfred February 5, 2022 19:06
This takes the `Schema` class (originally from NVT) and swaps the read/write functionality for importing/exporting Tensorflow Metadata protobuf files over to `better-proto`, but without coupling the `Schema` class directly to the file format.
@karlhigley karlhigley changed the title (WIP) Migrate Schema class to use better-proto for IO Migrate Schema class to use better-proto for IO Feb 6, 2022
@karlhigley karlhigley marked this pull request as ready for review February 6, 2022 22:21
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

I've added betterproto to the requirements.txt in an attempt to push the CI along.

merlin/graph/schema.py Show resolved Hide resolved
merlin/graph/schema_io/tensorflow_metadata.py Show resolved Hide resolved
@benfred benfred merged commit 70fa62c into main Feb 8, 2022
@benfred benfred deleted the refactor/schema-io branch February 8, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants