Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split gpu ci workflow into single-gpu and multi-gpu #151

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Jun 4, 2023

This PR splits the GPU CI Github Actions workflow into two jobs: one for the 1GPU runner, and one for multi-gpu 2GPU runner.

Two tests are marked with the @pytest.mark.multigpu marker to run them on 2GPU:

  • tests/unit/dataloader/test_tf_dataloader.py
  • examples/02-Multi-GPU-Tensorflow-with-Horovod.ipynb

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edknv edknv force-pushed the ci/test-multi-gpu branch from a25724d to 62850a6 Compare June 4, 2023 22:42
@edknv edknv self-assigned this Jun 4, 2023
@edknv edknv added the ci label Jun 4, 2023
@edknv edknv added this to the Merlin 23.06 milestone Jun 4, 2023
@edknv edknv force-pushed the ci/test-multi-gpu branch from 62850a6 to a47b394 Compare June 4, 2023 23:44
@edknv edknv force-pushed the ci/test-multi-gpu branch from a47b394 to af16de0 Compare June 4, 2023 23:52
@edknv edknv force-pushed the ci/test-multi-gpu branch from f8d981e to 8239008 Compare June 8, 2023 06:09
@edknv edknv force-pushed the ci/test-multi-gpu branch from 1114f68 to e193ae1 Compare June 8, 2023 06:32
@nv-alaiacano
Copy link
Contributor

Contributes to NVIDIA-Merlin/Merlin#992

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/dataloader/review/pr-151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants