Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Add/Fix the doc strings for TF based session based API documentation #1078

Closed
bbozkaya opened this issue May 2, 2023 · 2 comments · Fixed by #1106 or #1110
Closed

[Task] Add/Fix the doc strings for TF based session based API documentation #1078

bbozkaya opened this issue May 2, 2023 · 2 comments · Fixed by #1106 or #1110
Assignees
@gabrielspmoreira @marcromeyn @sararb @edknv
Labels
area/session-based documentation Improvements or additions to documentation
Milestone
Merlin 23.05

Comments

@bbozkaya
Copy link
Contributor

bbozkaya commented May 2, 2023 •
edited by viswa-nvidia
Loading

Related: NVIDIA-Merlin/Merlin#433
Note: For 23.05 we will only focus on findings related to session based in the API review doc posted by Burcin below
@bbozkaya bbozkaya added this to the Merlin 23.05 milestone May 2, 2023
@bbozkaya bbozkaya added documentation Improvements or additions to documentation area/session-based labels May 2, 2023
@bbozkaya
Copy link
Contributor Author

bbozkaya commented May 3, 2023

Completed review of API documentation (generated by docstrings in code) for Merlin Models codebase. Details are available here: https://docs.google.com/document/d/1v4rk2-pW34swfbDWz_d41ADlXjUcT9Yoc_xO3YgN02U/edit

@viswa-nvidia viswa-nvidia mentioned this issue May 9, 2023
Closed
37 tasks
@viswa-nvidia viswa-nvidia linked a pull request May 23, 2023 that will close this issue
Add docstrings #1106
Merged
@viswa-nvidia
Copy link

@nv-alaiacano , please merge the changes to 23.05 release branch and close this ticket.

@edknv edknv linked a pull request May 23, 2023 that will close this issue
Add docstrings #1110
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielspmoreira gabrielspmoreira

@marcromeyn marcromeyn

@sararb sararb

@edknv edknv

Labels
area/session-based documentation Improvements or additions to documentation
Projects
None yet
Milestone
Merlin 23.05
Development

Successfully merging a pull request may close this issue.

Add docstrings edknv/models
Add docstrings NVIDIA-Merlin/models
6 participants
@gabrielspmoreira @marcromeyn @sararb @bbozkaya @viswa-nvidia @edknv