Add docstrings #1106
Merged
Add docstrings #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edknv
added
documentation
edknv
commented
May 22, 2023
| @@ -44,7 +44,6 @@ def InputBlock( | |||
| post: Optional[BlockType] = None, | |||
| aggregation: Optional[TabularAggregationType] = None, | |||
| seq: bool = False, | |||
| max_seq_length: Optional[int] = None, | |||
There was a problem hiding this comment.
This argument max_seq_length is removed because it doesn't seem to be used anywhere in the function.
|
I'll go ahead and merge this since this PR will be merged to |
edknv
added a commit
that referenced
this pull request
Jun 12, 2023
* Fixed docstrings * [WIP] add docstrings in mms classes and functions (#1101) * add docstings * add docstrings * Add docstrings (#1106) * Add docstrings to Encoder * Add docstrings to ItemRetrievalScorer * Add docstrings to Model * Fix docstring for TwoTowerModel * Add docstring to YoutubeDNNRetrievalModelV2 * Add docstrings to L2Norm * Add docstrings to ContinuousFeatures * Add docstrings to AverageEmbeddingsByWeightFeature * Add docstrings to ReplaceMaskedEmbeddings * Add docstrings to SequenceEmbeddingFeatures * Add docstrings to EmbeddingTable * lint * lint * lint * update docstring syntax --------- Co-authored-by: Gabriel Moreira <[email protected]> Co-authored-by: rnyak <[email protected]> Co-authored-by: Adam Laiacano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR will be merged to
tf/doc_strings_update(not main).