Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples spanning multiple repos / promote ecommerce session-based example #1160

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

radekosmulski
Copy link
Contributor

This is part of NVIDIA-Merlin/Merlin#1027. We are moving examples spanning multiple repositories to Merlin and performing some miscellaneous cleanup.

Blocked by: NVIDIA-Merlin/Merlin#1028

(we need to merge the other PR first, add the notebooks, and then remove the notebooks here and create appropriate links)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@radekosmulski radekosmulski marked this pull request as draft June 27, 2023 06:52
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1160

@radekosmulski radekosmulski force-pushed the move_and_remove_examples branch 2 times, most recently from c5320ce to db29aa2 Compare June 27, 2023 08:18
@radekosmulski radekosmulski marked this pull request as ready for review July 3, 2023 23:56
@radekosmulski radekosmulski marked this pull request as draft July 3, 2023 23:56
…ased example

* Remove 2 examples (move to Merlin)
* Move session-based ecommerce example one level up, from usecases to
  examples
* Delete benchmarking (asvdb) test (move to Merlin)
@radekosmulski radekosmulski force-pushed the move_and_remove_examples branch from 3ad4363 to 9bc9352 Compare July 6, 2023 04:16
@radekosmulski radekosmulski marked this pull request as ready for review July 6, 2023 04:16
@radekosmulski radekosmulski changed the title [WIP] Remove examples spanning multiple repos / promote ecommerce session-based example Remove examples spanning multiple repos / promote ecommerce session-based example Jul 6, 2023
@radekosmulski radekosmulski merged commit 9922f25 into main Jul 6, 2023
@radekosmulski radekosmulski deleted the move_and_remove_examples branch July 6, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants